Skip to content

Correct handling of string paths #66

@Krzyhau

Description

@Krzyhau

Some properties in assets represent partial paths to other assets. The game verifies if those properties are null to avoid executing logic without the path being set. However, this does not apply for empty strings. Previously, this issue was silently mitigated by Repacker, which was serializing all empty strings to null. However, since v1.3.0, the distinction between empty strings and null values is properly handled, causing this issue to surface. Since Repacker's job is to represent the game's data as accurately as possible, it is in editor's intention to properly prepare said data. I think all properties which reference other assets should be handled in a way so that they contain null if path is not assigned, instead of empty string.

This definitely have to be handled for Level properties like SongName and GomezHaloName. Other assets should probably follow this logic as well (isn't Sky asset referencing other texture assets in some properties?)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions