Use environmental variables and Docker container (#1)

Author: chilagrow

ferret.yml

@@ -15,6 +15,15 @@ services:
     environment:
       - FERRETDB_POSTGRESQL_URL=postgres://postgres:5432/ferretdb
 
+  legacy-mongo:
+    image: mongodb/mongodb-community-server:5.0.30-ubuntu2004
+    container_name: legacy-mongo
+    command: sleep 86400
+    extra_hosts:
+      - "host.docker.internal:host-gateway"
+    volumes:
+      - ${TEST_DIRECTORY:-mongo/jstests}:/jstests
+
 networks:
   default:
     name: ferretdb

maxscale.yml

@@ -16,6 +16,15 @@ services:
     volumes:
       - ./config/maxscale.cnf:/etc/maxscale.cnf
 
+  legacy-mongo:
+    image: mongodb/mongodb-community-server:5.0.30-ubuntu2004
+    container_name: legacy-mongo
+    command: sleep 86400
+    extra_hosts:
+      - "host.docker.internal:host-gateway"
+    volumes:
+      - ${TEST_DIRECTORY:-./mongo/jstests}:/jstests
+
 networks:
   default:
     name: mariadb

mongo5.yml

@@ -10,6 +10,15 @@ services:
       - MONGO_INITDB_ROOT_USERNAME=admin
       - MONGO_INITDB_ROOT_PASSWORD=password
 
+  legacy-mongo:
+    image: mongodb/mongodb-community-server:5.0.30-ubuntu2004
+    container_name: legacy-mongo
+    command: sleep 86400
+    extra_hosts:
+      - "host.docker.internal:host-gateway"
+    volumes:
+      - ${TEST_DIRECTORY:-./mongo/jstests}:/jstests
+
 networks:
   default:
     name: mongo

mongo7.yml

@@ -10,6 +10,15 @@ services:
       - MONGO_INITDB_ROOT_USERNAME=admin
       - MONGO_INITDB_ROOT_PASSWORD=password
 
+  legacy-mongo:
+    image: mongodb/mongodb-community-server:5.0.30-ubuntu2004
+    container_name: legacy-mongo
+    command: sleep 86400
+    extra_hosts:
+      - "host.docker.internal:host-gateway"
+    volumes:
+      - ${TEST_DIRECTORY:-./mongo/jstests}:/jstests
+
 networks:
   default:
     name: mongo

mongo8.yml

@@ -10,6 +10,15 @@ services:
       - MONGO_INITDB_ROOT_USERNAME=admin
       - MONGO_INITDB_ROOT_PASSWORD=password
 
+  legacy-mongo:
+    image: mongodb/mongodb-community-server:5.0.30-ubuntu2004
+    container_name: legacy-mongo
+    command: sleep 86400
+    extra_hosts:
+      - "host.docker.internal:host-gateway"
+    volumes:
+      - ${TEST_DIRECTORY:-./mongo/jstests}:/jstests
+
 networks:
   default:
     name: mongo

run.py

@@ -4,8 +4,6 @@
 import subprocess
 import sys
 import time
-from pymongo import MongoClient
-from pymongo.errors import ConnectionFailure, OperationFailure
 
 # Constants
 VERSIONS = ["5", "7", "8"]
@@ -14,19 +12,21 @@
 SKIP_DIRECTORY = "skip"
 COMMON_SKIP_FILE = "common.txt"
 LOG_FILE_PATH = os.path.join(LOG_DIRECTORY, LOG_FILENAME)
-TEST_DIRECTORY = os.path.join(os.getcwd(), "mongo/jstests")
 COMMON_LIST = os.path.join(SKIP_DIRECTORY, COMMON_SKIP_FILE)
+DOCKER_DIRECTORY = "/jstests"
 
 # User Variables (Consider moving these to a config file or environment variables)
 # Note: No username/password required for MaxScale test
-MONGO_HOST = "127.0.0.1"
-MONGO_PORT = 27017
-MONGO_USERNAME = "admin"
-MONGO_PASSWORD = "password"
+MONGO_HOST = os.environ.get("MONGO_HOST", "host.docker.internal")
+MONGO_PORT = int(os.environ.get("MONGO_PORT", 27017))
+MONGO_USERNAME = os.environ.get("MONGO_USERNAME", "admin")
+MONGO_PASSWORD = os.environ.get("MONGO_PASSWORD", "password")
 AUTHENTICATION_DATABASE = "admin"
 AUTHENTICATION_MECHANISM = "SCRAM-SHA-1"
 USE_SSL = "false"
 LOAD_BALANCE = "false"
+TEST_DIRECTORY = os.environ.get("TEST_DIRECTORY", os.path.join(os.getcwd(), "mongo/jstests"))
+DOCKER_COMMAND = f"docker compose exec legacy-mongo mongo" # requires envVar set for compose file such as `export COMPOSE_FILE=mongo5.yml`
 
 if MONGO_USERNAME and MONGO_PASSWORD:
     creds = f"{MONGO_USERNAME}:{MONGO_PASSWORD}@"
@@ -49,17 +49,22 @@ def check_list_existence(file_path, file_description):
 
 # Validate MongoDB connectivity and credentials.
 def validate_connection(uri):
+    ping_command = DOCKER_COMMAND.split() + ["--eval", "db.runCommand({ping: 1})", uri]
     try:
-        client = MongoClient(uri, serverSelectionTimeoutMS=5000)
-        client[AUTHENTICATION_DATABASE].command("ping")
+        subprocess.run(
+            ping_command,
+            check=True,
+            stdout=subprocess.PIPE,
+            stderr=subprocess.STDOUT,
+            timeout=30,
+        )
         print("Connected successfully to database")
-
-    except ConnectionFailure:
-        print("\033[91mFailed to connect to database\033[0m")
+    except subprocess.TimeoutExpired:
+        print("\033[91mFailed to connect to database: timeout \033[0m")
         sys.exit(1)
-
-    except OperationFailure:
-        print("\033[91mAuthentication failed for database\033[0m")
+    except subprocess.CalledProcessError as e:
+        msg = f"Failed to connect to database: {e.output}"
+        print("\033[91m" + msg + "\033[0m")
         sys.exit(1)
 
 
@@ -70,13 +75,14 @@ def create_mongo_uri():
 
 # Build the mongo command with the necessary arguments.
 def build_mongo_command(script_path):
-    mongo_command = ["mongo", f"mongodb://{creds}{MONGO_HOST}:{MONGO_PORT}/{auth_part}"]
+    mongo_command = DOCKER_COMMAND.split() + [f"mongodb://{creds}{MONGO_HOST}:{MONGO_PORT}/{auth_part}"]
     mongo_command.append(script_path)
     return mongo_command
 
 
 # Run an individual script using subprocess.
 def run_script(script_path):
+    script_path = os.path.join(DOCKER_DIRECTORY, script_path)
     mongo_command = build_mongo_command(script_path)
     # print(mongo_command)
     try:
@@ -92,25 +98,27 @@ def run_script(script_path):
         return False
 
 
-# Find all JS files that are not in the exclusion lists.
+# Find all JS files that are not in the exclusion lists relative to the given directory.
 def find_js_files(directory, mongo_version):
     exclusions = set()
     with open(COMMON_LIST, "r") as f:
-        exclusions.update([TEST_DIRECTORY + line.strip() for line in f])
+        exclusions.update([line.strip() for line in f])
 
     # Add specific mongo version exclusions.
     mongo_exclusions = f"{SKIP_DIRECTORY}/mongo{mongo_version}.txt"
     check_list_existence(mongo_exclusions, mongo_exclusions)
     with open(mongo_exclusions, "r") as f:
-        exclusions.update([TEST_DIRECTORY + line.strip() for line in f])
+        exclusions.update([line.strip() for line in f])
 
     js_files = []
     for root, dirs, files in os.walk(directory):
         for file in files:
             if file.endswith(".js"):
                 full_path = os.path.join(root, file)
-                if full_path not in exclusions:
-                    js_files.append(full_path)
+                relative_path = os.path.relpath(full_path, directory)
+                # exclusions files such as `skip/common.txt` contain path prefixed with "/"
+                if os.path.join("/", relative_path) not in exclusions:
+                    js_files.append(relative_path)
 
     if not js_files:
         print(f"No JS files found in {directory}")