Skip to content

Commit e001c8d

Browse files
millasmlMilla Samuel
andauthored
Dont Run Modify Sub Reconciler if Encryption Key Path is Present (#2394)
* Dont modify if encrypted --------- Co-authored-by: Milla Samuel <[email protected]>
1 parent 1ebb6f1 commit e001c8d

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

controllers/modify_backup.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,13 @@ func (s modifyBackup) reconcile(
4141
return nil
4242
}
4343

44+
// Modifying backups will remove encryption from previously encrypted backups.
45+
// To preserve encryption, skip backup modifications if encryption is enabled.
46+
// See FoundationDB issue: https://github.com/apple/foundationdb/issues/12544
47+
if backup.Spec.EncryptionKeyPath != "" {
48+
return nil
49+
}
50+
4451
// The modify command is only required for continuous backups.
4552
if backup.NeedsBackupReconfiguration() &&
4653
backup.GetBackupMode() == fdbv1beta2.BackupModeContinuous {

0 commit comments

Comments
 (0)