Upgrade to geos 3.14.0 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the library to the geos 3.14.0 release. This release brings a bunch of fixes over 3.13.0 as well as adding some nice new features to the C API like M coordinate support and clustering operations.
There are some small breaking changes in the geos release worth discussing if this should be a major or minor SemVer bump here--this commit currently does a minor bump. Notable breaks are stricter WKT parsing and emitting an error when setting an ordinate that doesn't exist. For the purpose of consumption be GEOSwift, this shouldn't be breaking, but those using this library directly may feel a major bump is more appropriate.
I tested the full build matrix (Apple/linux, Xcode/SPM) with the exception of CocoaPods. I don't have CocoaPods installed anymore, and it's worth discussing dropping CocoaPods support given it is winding down. Many major Swift libraries have already moved this direction.
Let me know on the version change and if there is anything else!