From 6d879aa504f153141ae796891070838f6310c6be Mon Sep 17 00:00:00 2001 From: "D.Super" <6484766+SuperDJ@users.noreply.github.com> Date: Fri, 6 Nov 2026 10:07:21 +0100 Subject: [PATCH 1/3] Remove unused dependencies and declare missing ones Remove packages that nothing uses: - Root: @babel/cli, @rollup/plugin-typescript, coveralls, bytes, gzip-size and @types/eslint. - workbox-build: @babel/runtime, which isn't imported, as bundling uses babelHelpers: 'bundled'. Also drop its dependency-check ignore entries. - infra/pr-bot/aggregate-size-plugin.js, which nothing loads and which imports the undeclared pr-bot. It was the only user of bytes and gzip-size. Declare packages that were used but missing: - type-fest moves from the root to workbox-build, whose published types import it. - body-parser is added to the 13 demo manifests that require it. workbox-build was compiling against type-fest 0.16.0, hoisted from tempy, rather than the 3.13.1 declared at the root. Using 3.13.1 fails with TS2411 on the WorkboxPackageJSON interface, so it is now a type alias with the same shape. --- .../workbox-background-sync-demo/package.json | 1 + .../package.json | 1 + .../workbox-cacheable-response/package.json | 1 + demos/src/workbox-core/package.json | 1 + demos/src/workbox-expiration/package.json | 1 + .../src/workbox-google-analytics/package.json | 1 + .../workbox-navigation-preload/package.json | 1 + demos/src/workbox-precaching/package.json | 1 + demos/src/workbox-range-requests/package.json | 1 + demos/src/workbox-routing/package.json | 1 + demos/src/workbox-streams/package.json | 1 + demos/src/workbox-sw/package.json | 1 + demos/src/workbox-window/package.json | 1 + infra/pr-bot/aggregate-size-plugin.js | 87 ------ package-lock.json | 274 ------------------ package.json | 7 - packages/workbox-build/package-lock.json | 49 ++-- packages/workbox-build/package.json | 2 +- packages/workbox-build/src/types.ts | 4 +- test/workbox-build/node/dependency-check.js | 1 - test/workbox-cli/node/dependency-check.js | 1 - .../node/dependency-check.js | 1 - 22 files changed, 43 insertions(+), 396 deletions(-) delete mode 100644 infra/pr-bot/aggregate-size-plugin.js diff --git a/demos/src/workbox-background-sync-demo/package.json b/demos/src/workbox-background-sync-demo/package.json index b8d4a9e63..78f014ad6 100644 --- a/demos/src/workbox-background-sync-demo/package.json +++ b/demos/src/workbox-background-sync-demo/package.json @@ -6,6 +6,7 @@ "start": "node updateServer.js" }, "dependencies": { + "body-parser": "^1.20.2", "express": "^4.17.1" }, "engines": { diff --git a/demos/src/workbox-broadcast-update-demo/package.json b/demos/src/workbox-broadcast-update-demo/package.json index 0651ee960..2e074220e 100644 --- a/demos/src/workbox-broadcast-update-demo/package.json +++ b/demos/src/workbox-broadcast-update-demo/package.json @@ -6,6 +6,7 @@ "start": "node updateServer.js" }, "dependencies": { + "body-parser": "^1.20.2", "express": "^4.17.1" }, "engines": { diff --git a/demos/src/workbox-cacheable-response/package.json b/demos/src/workbox-cacheable-response/package.json index b285fff05..1934627be 100644 --- a/demos/src/workbox-cacheable-response/package.json +++ b/demos/src/workbox-cacheable-response/package.json @@ -7,6 +7,7 @@ "start": "node server.js" }, "dependencies": { + "body-parser": "^1.20.2", "express": "^4.17.1" }, "engines": { diff --git a/demos/src/workbox-core/package.json b/demos/src/workbox-core/package.json index 2c3034b14..6d54d7a4a 100644 --- a/demos/src/workbox-core/package.json +++ b/demos/src/workbox-core/package.json @@ -6,6 +6,7 @@ "start": "node updateServer.js" }, "dependencies": { + "body-parser": "^1.20.2", "express": "^4.17.1" }, "engines": { diff --git a/demos/src/workbox-expiration/package.json b/demos/src/workbox-expiration/package.json index 565ccbc44..21f6a1906 100644 --- a/demos/src/workbox-expiration/package.json +++ b/demos/src/workbox-expiration/package.json @@ -6,6 +6,7 @@ "start": "node updateServer.js" }, "dependencies": { + "body-parser": "^1.20.2", "express": "^4.17.1" }, "engines": { diff --git a/demos/src/workbox-google-analytics/package.json b/demos/src/workbox-google-analytics/package.json index fd219b7ea..7cd3ee59e 100644 --- a/demos/src/workbox-google-analytics/package.json +++ b/demos/src/workbox-google-analytics/package.json @@ -6,6 +6,7 @@ "start": "node updateServer.js" }, "dependencies": { + "body-parser": "^1.20.2", "express": "^4.17.1" }, "engines": { diff --git a/demos/src/workbox-navigation-preload/package.json b/demos/src/workbox-navigation-preload/package.json index 07fd53505..e97681163 100644 --- a/demos/src/workbox-navigation-preload/package.json +++ b/demos/src/workbox-navigation-preload/package.json @@ -6,6 +6,7 @@ "start": "node updateServer.js" }, "dependencies": { + "body-parser": "^1.20.2", "express": "^4.17.1" }, "engines": { diff --git a/demos/src/workbox-precaching/package.json b/demos/src/workbox-precaching/package.json index f5b19e382..36a50e5a9 100644 --- a/demos/src/workbox-precaching/package.json +++ b/demos/src/workbox-precaching/package.json @@ -6,6 +6,7 @@ "start": "node updateServer.js" }, "dependencies": { + "body-parser": "^1.20.2", "express": "^4.17.1" }, "engines": { diff --git a/demos/src/workbox-range-requests/package.json b/demos/src/workbox-range-requests/package.json index 862e8e232..0529df28e 100644 --- a/demos/src/workbox-range-requests/package.json +++ b/demos/src/workbox-range-requests/package.json @@ -6,6 +6,7 @@ "start": "node updateServer.js" }, "dependencies": { + "body-parser": "^1.20.2", "express": "^4.17.1" }, "engines": { diff --git a/demos/src/workbox-routing/package.json b/demos/src/workbox-routing/package.json index b52bcdaf7..ad3860f3a 100644 --- a/demos/src/workbox-routing/package.json +++ b/demos/src/workbox-routing/package.json @@ -6,6 +6,7 @@ "start": "node updateServer.js" }, "dependencies": { + "body-parser": "^1.20.2", "express": "^4.17.1" }, "engines": { diff --git a/demos/src/workbox-streams/package.json b/demos/src/workbox-streams/package.json index e1257b19d..cbee6532c 100644 --- a/demos/src/workbox-streams/package.json +++ b/demos/src/workbox-streams/package.json @@ -6,6 +6,7 @@ "start": "node server.js" }, "dependencies": { + "body-parser": "^1.20.2", "express": "^4.17.1" }, "engines": { diff --git a/demos/src/workbox-sw/package.json b/demos/src/workbox-sw/package.json index c52f27f94..6b677f604 100644 --- a/demos/src/workbox-sw/package.json +++ b/demos/src/workbox-sw/package.json @@ -6,6 +6,7 @@ "start": "node updateServer.js" }, "dependencies": { + "body-parser": "^1.20.2", "express": "^4.17.1" }, "engines": { diff --git a/demos/src/workbox-window/package.json b/demos/src/workbox-window/package.json index c2dc2c47e..cf61187ff 100644 --- a/demos/src/workbox-window/package.json +++ b/demos/src/workbox-window/package.json @@ -6,6 +6,7 @@ "start": "node updateServer.js" }, "dependencies": { + "body-parser": "^1.20.2", "express": "^4.17.1" }, "engines": { diff --git a/infra/pr-bot/aggregate-size-plugin.js b/infra/pr-bot/aggregate-size-plugin.js deleted file mode 100644 index d255dd238..000000000 --- a/infra/pr-bot/aggregate-size-plugin.js +++ /dev/null @@ -1,87 +0,0 @@ -/* - Copyright 2018 Google LLC - - Use of this source code is governed by an MIT-style - license that can be found in the LICENSE file or at - https://opensource.org/licenses/MIT. -*/ - -const {oneLine} = require('common-tags'); -const {PluginInterface} = require('pr-bot'); -const bytes = require('bytes'); -const fs = require('fs-extra'); -const gzipSize = require('gzip-size'); -const path = require('path'); - -// 15kb max size, gzip'ed. -const MAX_SIZE_GZIP = 15 * 1024; - -class AggregateSizePlugin extends PluginInterface { - constructor() { - super(`Workbox Aggregate Size Plugin`); - } - - async run({afterPath} = {}) { - const packagesToAggregate = [ - `workbox-cacheable-response`, - `workbox-core`, - `workbox-expiration`, - `workbox-precaching`, - `workbox-routing`, - `workbox-strategies`, - `workbox-sw`, - ]; - - const absoluteAfterPath = path.resolve(afterPath); - const files = packagesToAggregate.map((pkgName) => { - const prefix = `${absoluteAfterPath}/packages/${pkgName}/`; - const pkgJson = require(`${prefix}package.json`); - const posixPath = prefix + pkgJson.main; - return posixPath.split('/').join(path.sep); - }); - - let totalSize = 0; - let totalGzipSize = 0; - - for (const filePath of files) { - const fileContents = await fs.readFile(filePath); - const stat = await fs.stat(filePath); - totalSize += stat.size; - totalGzipSize += await gzipSize(fileContents); - } - - const percentValue = (totalGzipSize / MAX_SIZE_GZIP) * 100; - const percentString = parseFloat(percentValue).toFixed(0); - - const totalSizeString = bytes(totalSize); - const totalGzipString = bytes(totalGzipSize); - - let markdownWarning = ``; - if (percentValue >= 90) { - const markdownMoji = percentValue >= 95 ? '☠️' : '⚠️'; - markdownWarning = oneLine` -
- We are using ${percentString}% - of our max budget for gzip'ed bundle size. -
`; - } - - const failPR = Boolean(percentValue > 100); - - const prettyLog = - `**${totalGzipString}** gzip'ed ` + - `(**${percentString}%** of limit)\n` + - `**${totalSizeString}** uncompressed`; - - const markdownLog = `${markdownWarning}\n\n${prettyLog}`; - - return { - failPR, // Fail the PR if we have exceeded the limit. - markdownLog, - prettyLog, - }; - } -} - -module.exports = AggregateSizePlugin; diff --git a/package-lock.json b/package-lock.json index 3414d2b70..7d01c3fc3 100644 --- a/package-lock.json +++ b/package-lock.json @@ -7,7 +7,6 @@ "name": "workbox", "license": "MIT", "devDependencies": { - "@babel/cli": "^7.24.1", "@babel/core": "^7.24.4", "@babel/preset-env": "^7.11.0", "@google-cloud/storage": "^5.20.5", @@ -18,11 +17,9 @@ "@rollup/plugin-node-resolve": "^16.0.3", "@rollup/plugin-replace": "^6.0.3", "@rollup/plugin-terser": "^1.0.0", - "@rollup/plugin-typescript": "^12.3.0", "@types/babel__core": "^7.20.5", "@types/babel__preset-env": "^7.9.6", "@types/common-tags": "^1.8.4", - "@types/eslint": "^8.56.10", "@types/estree": "^1.0.5", "@types/fs-extra": "^9.0.13", "@types/node": "^20.14.8", @@ -33,7 +30,6 @@ "babel-plugin-transform-async-to-promises": "^0.8.18", "babylon": "^6.18.0", "body-parser": "^1.20.2", - "bytes": "^3.1.2", "camelcase": "^6.3.0", "chai": "^4.4.1", "chai-as-promised": "^7.1.1", @@ -43,7 +39,6 @@ "comlink": "^4.4.1", "common-tags": "^1.8.2", "copy-webpack-plugin": "^6.4.1", - "coveralls": "^3.1.1", "del": "^5.1.0", "depcheck": "^1.4.7", "eslint": "^7.32.0", @@ -56,7 +51,6 @@ "glob": "^13.0.6", "globby": "^11.1.0", "gulp": "^4.0.2", - "gzip-size": "^5.1.1", "html-webpack-plugin-v4": "npm:html-webpack-plugin@^4.5.0", "html-webpack-plugin-v5": "npm:html-webpack-plugin@^5.0.0-alpha.14", "husky": "^7.0.4", @@ -81,7 +75,6 @@ "service-worker-mock": "^1.9.3", "sinon": "^9.0.3", "tempy": "^1.0.1", - "type-fest": "^3.13.1", "typescript": "^4.9.5", "typescript-json-schema": "^0.63.0", "upath": "^1.2.0", @@ -93,70 +86,6 @@ "node": ">=20.0.0" } }, - "node_modules/@babel/cli": { - "version": "7.24.1", - "dev": true, - "license": "MIT", - "dependencies": { - "@jridgewell/trace-mapping": "^0.3.25", - "commander": "^4.0.1", - "convert-source-map": "^2.0.0", - "fs-readdir-recursive": "^1.1.0", - "glob": "^7.2.0", - "make-dir": "^2.1.0", - "slash": "^2.0.0" - }, - "bin": { - "babel": "bin/babel.js", - "babel-external-helpers": "bin/babel-external-helpers.js" - }, - "engines": { - "node": ">=6.9.0" - }, - "optionalDependencies": { - "@nicolo-ribaudo/chokidar-2": "2.1.8-no-fsevents.3", - "chokidar": "^3.4.0" - }, - "peerDependencies": { - "@babel/core": "^7.0.0-0" - } - }, - "node_modules/@babel/cli/node_modules/@jridgewell/trace-mapping": { - "version": "0.3.25", - "dev": true, - "license": "MIT", - "dependencies": { - "@jridgewell/resolve-uri": "^3.1.0", - "@jridgewell/sourcemap-codec": "^1.4.14" - } - }, - "node_modules/@babel/cli/node_modules/convert-source-map": { - "version": "2.0.0", - "dev": true, - "license": "MIT" - }, - "node_modules/@babel/cli/node_modules/glob": { - "version": "7.2.3", - "resolved": "https://registry.npmjs.org/glob/-/glob-7.2.3.tgz", - "integrity": "sha512-nFR0zLpU2YCaRxwoCJvL6UvCH2JFyFVIvwTLsIf21AuHlMskA1hhTdk+LlYJtOlYt9v6dvszD2BGRqBL+iQK9Q==", - "deprecated": "Glob versions prior to v9 are no longer supported", - "dev": true, - "license": "ISC", - "dependencies": { - "fs.realpath": "^1.0.0", - "inflight": "^1.0.4", - "inherits": "2", - "minimatch": "^3.1.1", - "once": "^1.3.0", - "path-is-absolute": "^1.0.0" - }, - "engines": { - "node": "*" - }, - "funding": { - "url": "https://github.com/sponsors/isaacs" - } - }, "node_modules/@babel/code-frame": { "version": "7.29.7", "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.29.7.tgz", @@ -3809,12 +3738,6 @@ "node": "^22.20 || ^24.12 || >=25" } }, - "node_modules/@nicolo-ribaudo/chokidar-2": { - "version": "2.1.8-no-fsevents.3", - "dev": true, - "license": "MIT", - "optional": true - }, "node_modules/@nodelib/fs.scandir": { "version": "2.1.3", "dev": true, @@ -5015,33 +4938,6 @@ "node": ">=10" } }, - "node_modules/@rollup/plugin-typescript": { - "version": "12.3.0", - "resolved": "https://registry.npmjs.org/@rollup/plugin-typescript/-/plugin-typescript-12.3.0.tgz", - "integrity": "sha512-7DP0/p7y3t67+NabT9f8oTBFE6gGkto4SA6Np2oudYmZE/m1dt8RB0SjL1msMxFpLo631qjRCcBlAbq1ml/Big==", - "dev": true, - "license": "MIT", - "dependencies": { - "@rollup/pluginutils": "^5.1.0", - "resolve": "^1.22.1" - }, - "engines": { - "node": ">=14.0.0" - }, - "peerDependencies": { - "rollup": "^2.14.0||^3.0.0||^4.0.0", - "tslib": "*", - "typescript": ">=3.7.0" - }, - "peerDependenciesMeta": { - "rollup": { - "optional": true - }, - "tslib": { - "optional": true - } - } - }, "node_modules/@rollup/plugin-virtual": { "version": "3.0.2", "resolved": "https://registry.npmjs.org/@rollup/plugin-virtual/-/plugin-virtual-3.0.2.tgz", @@ -9472,24 +9368,6 @@ "node": ">=10" } }, - "node_modules/coveralls": { - "version": "3.1.1", - "dev": true, - "license": "BSD-2-Clause", - "dependencies": { - "js-yaml": "^3.13.1", - "lcov-parse": "^1.0.0", - "log-driver": "^1.2.7", - "minimist": "^1.2.5", - "request": "^2.88.2" - }, - "bin": { - "coveralls": "bin/coveralls.js" - }, - "engines": { - "node": ">=6" - } - }, "node_modules/create-ecdh": { "version": "4.0.4", "dev": true, @@ -12318,11 +12196,6 @@ "node": ">= 0.10" } }, - "node_modules/fs-readdir-recursive": { - "version": "1.1.0", - "dev": true, - "license": "MIT" - }, "node_modules/fs-write-stream-atomic": { "version": "1.0.10", "resolved": "https://registry.npmjs.org/fs-write-stream-atomic/-/fs-write-stream-atomic-1.0.10.tgz", @@ -13331,18 +13204,6 @@ "node": ">= 0.10" } }, - "node_modules/gzip-size": { - "version": "5.1.1", - "dev": true, - "license": "MIT", - "dependencies": { - "duplexer": "^0.1.1", - "pify": "^4.0.1" - }, - "engines": { - "node": ">=6" - } - }, "node_modules/handlebars": { "version": "4.7.9", "resolved": "https://registry.npmjs.org/handlebars/-/handlebars-4.7.9.tgz", @@ -15377,14 +15238,6 @@ "node": ">=0.10.0" } }, - "node_modules/lcov-parse": { - "version": "1.0.0", - "dev": true, - "license": "BSD-3-Clause", - "bin": { - "lcov-parse": "bin/cli.js" - } - }, "node_modules/lead": { "version": "1.0.0", "dev": true, @@ -15985,14 +15838,6 @@ "integrity": "sha512-jttmRe7bRse52OsWIMDLaXxWqRAmtIUccAQ3garviCqJjafXOfNMO0yMfNpdD6zbGaTU0P5Nz7e7gAT6cKmJRw==", "dev": true }, - "node_modules/log-driver": { - "version": "1.2.7", - "dev": true, - "license": "ISC", - "engines": { - "node": ">=0.8.6" - } - }, "node_modules/log-symbols": { "version": "4.1.0", "dev": true, @@ -21532,14 +21377,6 @@ "node": ">=8" } }, - "node_modules/slash": { - "version": "2.0.0", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=6" - } - }, "node_modules/slice-ansi": { "version": "4.0.0", "resolved": "https://registry.npmjs.org/slice-ansi/-/slice-ansi-4.0.0.tgz", @@ -23157,18 +22994,6 @@ "node": ">=4" } }, - "node_modules/type-fest": { - "version": "3.13.1", - "resolved": "https://registry.npmjs.org/type-fest/-/type-fest-3.13.1.tgz", - "integrity": "sha512-tLq3bSNx+xSpwvAJnzrK0Ep5CLNWjvFTOp71URMaAEWBfRb9nnJiBoUe0tF8bI4ZFO3omgBR6NvnbzVUT3Ly4g==", - "dev": true, - "engines": { - "node": ">=14.16" - }, - "funding": { - "url": "https://github.com/sponsors/sindresorhus" - } - }, "node_modules/type-is": { "version": "1.6.18", "dev": true, @@ -25493,49 +25318,6 @@ } }, "dependencies": { - "@babel/cli": { - "version": "7.24.1", - "dev": true, - "requires": { - "@jridgewell/trace-mapping": "^0.3.25", - "@nicolo-ribaudo/chokidar-2": "2.1.8-no-fsevents.3", - "chokidar": "^3.4.0", - "commander": "^4.0.1", - "convert-source-map": "^2.0.0", - "fs-readdir-recursive": "^1.1.0", - "glob": "^7.2.0", - "make-dir": "^2.1.0", - "slash": "^2.0.0" - }, - "dependencies": { - "@jridgewell/trace-mapping": { - "version": "0.3.25", - "dev": true, - "requires": { - "@jridgewell/resolve-uri": "^3.1.0", - "@jridgewell/sourcemap-codec": "^1.4.14" - } - }, - "convert-source-map": { - "version": "2.0.0", - "dev": true - }, - "glob": { - "version": "7.2.3", - "resolved": "https://registry.npmjs.org/glob/-/glob-7.2.3.tgz", - "integrity": "sha512-nFR0zLpU2YCaRxwoCJvL6UvCH2JFyFVIvwTLsIf21AuHlMskA1hhTdk+LlYJtOlYt9v6dvszD2BGRqBL+iQK9Q==", - "dev": true, - "requires": { - "fs.realpath": "^1.0.0", - "inflight": "^1.0.4", - "inherits": "2", - "minimatch": "^3.1.1", - "once": "^1.3.0", - "path-is-absolute": "^1.0.0" - } - } - } - }, "@babel/code-frame": { "version": "7.29.7", "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.29.7.tgz", @@ -28049,11 +27831,6 @@ "dev": true, "optional": true }, - "@nicolo-ribaudo/chokidar-2": { - "version": "2.1.8-no-fsevents.3", - "dev": true, - "optional": true - }, "@nodelib/fs.scandir": { "version": "2.1.3", "dev": true, @@ -28830,16 +28607,6 @@ } } }, - "@rollup/plugin-typescript": { - "version": "12.3.0", - "resolved": "https://registry.npmjs.org/@rollup/plugin-typescript/-/plugin-typescript-12.3.0.tgz", - "integrity": "sha512-7DP0/p7y3t67+NabT9f8oTBFE6gGkto4SA6Np2oudYmZE/m1dt8RB0SjL1msMxFpLo631qjRCcBlAbq1ml/Big==", - "dev": true, - "requires": { - "@rollup/pluginutils": "^5.1.0", - "resolve": "^1.22.1" - } - }, "@rollup/plugin-virtual": { "version": "3.0.2", "resolved": "https://registry.npmjs.org/@rollup/plugin-virtual/-/plugin-virtual-3.0.2.tgz", @@ -31873,17 +31640,6 @@ "yaml": "^1.10.0" } }, - "coveralls": { - "version": "3.1.1", - "dev": true, - "requires": { - "js-yaml": "^3.13.1", - "lcov-parse": "^1.0.0", - "log-driver": "^1.2.7", - "minimist": "^1.2.5", - "request": "^2.88.2" - } - }, "create-ecdh": { "version": "4.0.4", "dev": true, @@ -33844,10 +33600,6 @@ "through2": "^2.0.3" } }, - "fs-readdir-recursive": { - "version": "1.1.0", - "dev": true - }, "fs-write-stream-atomic": { "version": "1.0.10", "resolved": "https://registry.npmjs.org/fs-write-stream-atomic/-/fs-write-stream-atomic-1.0.10.tgz", @@ -34575,14 +34327,6 @@ "glogg": "^1.0.0" } }, - "gzip-size": { - "version": "5.1.1", - "dev": true, - "requires": { - "duplexer": "^0.1.1", - "pify": "^4.0.1" - } - }, "handlebars": { "version": "4.7.9", "resolved": "https://registry.npmjs.org/handlebars/-/handlebars-4.7.9.tgz", @@ -35932,10 +35676,6 @@ "invert-kv": "^1.0.0" } }, - "lcov-parse": { - "version": "1.0.0", - "dev": true - }, "lead": { "version": "1.0.0", "dev": true, @@ -36367,10 +36107,6 @@ "integrity": "sha512-jttmRe7bRse52OsWIMDLaXxWqRAmtIUccAQ3garviCqJjafXOfNMO0yMfNpdD6zbGaTU0P5Nz7e7gAT6cKmJRw==", "dev": true }, - "log-driver": { - "version": "1.2.7", - "dev": true - }, "log-symbols": { "version": "4.1.0", "dev": true, @@ -40154,10 +39890,6 @@ } } }, - "slash": { - "version": "2.0.0", - "dev": true - }, "slice-ansi": { "version": "4.0.0", "resolved": "https://registry.npmjs.org/slice-ansi/-/slice-ansi-4.0.0.tgz", @@ -41256,12 +40988,6 @@ "version": "4.0.8", "dev": true }, - "type-fest": { - "version": "3.13.1", - "resolved": "https://registry.npmjs.org/type-fest/-/type-fest-3.13.1.tgz", - "integrity": "sha512-tLq3bSNx+xSpwvAJnzrK0Ep5CLNWjvFTOp71URMaAEWBfRb9nnJiBoUe0tF8bI4ZFO3omgBR6NvnbzVUT3Ly4g==", - "dev": true - }, "type-is": { "version": "1.6.18", "dev": true, diff --git a/package.json b/package.json index c5ec4b287..3ff9098c6 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,6 @@ }, "description": "Top-level scripts and dependencies for the workbox monorepo. Not meant to be published to npm.", "devDependencies": { - "@babel/cli": "^7.24.1", "@babel/core": "^7.24.4", "@babel/preset-env": "^7.11.0", "@google-cloud/storage": "^5.20.5", @@ -16,11 +15,9 @@ "@rollup/plugin-node-resolve": "^16.0.3", "@rollup/plugin-replace": "^6.0.3", "@rollup/plugin-terser": "^1.0.0", - "@rollup/plugin-typescript": "^12.3.0", "@types/babel__core": "^7.20.5", "@types/babel__preset-env": "^7.9.6", "@types/common-tags": "^1.8.4", - "@types/eslint": "^8.56.10", "@types/estree": "^1.0.5", "@types/fs-extra": "^9.0.13", "@types/node": "^20.14.8", @@ -31,7 +28,6 @@ "babel-plugin-transform-async-to-promises": "^0.8.18", "babylon": "^6.18.0", "body-parser": "^1.20.2", - "bytes": "^3.1.2", "camelcase": "^6.3.0", "chai": "^4.4.1", "chai-as-promised": "^7.1.1", @@ -41,7 +37,6 @@ "comlink": "^4.4.1", "common-tags": "^1.8.2", "copy-webpack-plugin": "^6.4.1", - "coveralls": "^3.1.1", "del": "^5.1.0", "depcheck": "^1.4.7", "eslint": "^7.32.0", @@ -54,7 +49,6 @@ "glob": "^13.0.6", "globby": "^11.1.0", "gulp": "^4.0.2", - "gzip-size": "^5.1.1", "html-webpack-plugin-v4": "npm:html-webpack-plugin@^4.5.0", "html-webpack-plugin-v5": "npm:html-webpack-plugin@^5.0.0-alpha.14", "husky": "^7.0.4", @@ -79,7 +73,6 @@ "service-worker-mock": "^1.9.3", "sinon": "^9.0.3", "tempy": "^1.0.1", - "type-fest": "^3.13.1", "typescript": "^4.9.5", "typescript-json-schema": "^0.63.0", "upath": "^1.2.0", diff --git a/packages/workbox-build/package-lock.json b/packages/workbox-build/package-lock.json index aa9fef22f..90fb49238 100644 --- a/packages/workbox-build/package-lock.json +++ b/packages/workbox-build/package-lock.json @@ -12,7 +12,6 @@ "@apideck/better-ajv-errors": "^0.3.1", "@babel/core": "^7.24.4", "@babel/preset-env": "^7.11.0", - "@babel/runtime": "^7.27.1", "@rollup/plugin-babel": "^7.1.0", "@rollup/plugin-node-resolve": "^16.0.3", "@rollup/plugin-replace": "^6.0.3", @@ -30,6 +29,7 @@ "stringify-object": "^3.3.0", "strip-comments": "^2.0.1", "tempy": "^1.0.1", + "type-fest": "^3.13.1", "upath": "^1.2.0" }, "devDependencies": { @@ -1598,15 +1598,6 @@ "@babel/core": "^7.0.0-0 || ^8.0.0-0 <8.0.0" } }, - "node_modules/@babel/runtime": { - "version": "7.29.7", - "resolved": "https://registry.npmjs.org/@babel/runtime/-/runtime-7.29.7.tgz", - "integrity": "sha512-Nq8OhGWiZIZGV6hLHoyAKLLcJihP/xFeBMGJoUrxTX2psI8dCifzLhZISFb+VWS3wFMRDmCGw5R+dOySCqPLhw==", - "license": "MIT", - "engines": { - "node": ">=6.9.0" - } - }, "node_modules/@babel/template": { "version": "7.29.7", "resolved": "https://registry.npmjs.org/@babel/template/-/template-7.29.7.tgz", @@ -4935,6 +4926,18 @@ "url": "https://github.com/sponsors/sindresorhus" } }, + "node_modules/tempy/node_modules/type-fest": { + "version": "0.16.0", + "resolved": "https://registry.npmjs.org/type-fest/-/type-fest-0.16.0.tgz", + "integrity": "sha512-eaBzG6MxNzEn9kiwvtre90cXaNLkmadMWa1zQMs3XORCXNbsH/OewwbxC5ia9dCxIxnTAsSxXJaa/p5y8DlvJg==", + "license": "(MIT OR CC0-1.0)", + "engines": { + "node": ">=10" + }, + "funding": { + "url": "https://github.com/sponsors/sindresorhus" + } + }, "node_modules/terser": { "version": "5.18.2", "resolved": "https://registry.npmjs.org/terser/-/terser-5.18.2.tgz", @@ -4965,12 +4968,12 @@ } }, "node_modules/type-fest": { - "version": "0.16.0", - "resolved": "https://registry.npmjs.org/type-fest/-/type-fest-0.16.0.tgz", - "integrity": "sha512-eaBzG6MxNzEn9kiwvtre90cXaNLkmadMWa1zQMs3XORCXNbsH/OewwbxC5ia9dCxIxnTAsSxXJaa/p5y8DlvJg==", + "version": "3.13.1", + "resolved": "https://registry.npmjs.org/type-fest/-/type-fest-3.13.1.tgz", + "integrity": "sha512-tLq3bSNx+xSpwvAJnzrK0Ep5CLNWjvFTOp71URMaAEWBfRb9nnJiBoUe0tF8bI4ZFO3omgBR6NvnbzVUT3Ly4g==", "license": "(MIT OR CC0-1.0)", "engines": { - "node": ">=10" + "node": ">=14.16" }, "funding": { "url": "https://github.com/sponsors/sindresorhus" @@ -6257,11 +6260,6 @@ "esutils": "^2.0.2" } }, - "@babel/runtime": { - "version": "7.29.7", - "resolved": "https://registry.npmjs.org/@babel/runtime/-/runtime-7.29.7.tgz", - "integrity": "sha512-Nq8OhGWiZIZGV6hLHoyAKLLcJihP/xFeBMGJoUrxTX2psI8dCifzLhZISFb+VWS3wFMRDmCGw5R+dOySCqPLhw==" - }, "@babel/template": { "version": "7.29.7", "resolved": "https://registry.npmjs.org/@babel/template/-/template-7.29.7.tgz", @@ -8289,6 +8287,13 @@ "temp-dir": "^2.0.0", "type-fest": "^0.16.0", "unique-string": "^2.0.0" + }, + "dependencies": { + "type-fest": { + "version": "0.16.0", + "resolved": "https://registry.npmjs.org/type-fest/-/type-fest-0.16.0.tgz", + "integrity": "sha512-eaBzG6MxNzEn9kiwvtre90cXaNLkmadMWa1zQMs3XORCXNbsH/OewwbxC5ia9dCxIxnTAsSxXJaa/p5y8DlvJg==" + } } }, "terser": { @@ -8311,9 +8316,9 @@ } }, "type-fest": { - "version": "0.16.0", - "resolved": "https://registry.npmjs.org/type-fest/-/type-fest-0.16.0.tgz", - "integrity": "sha512-eaBzG6MxNzEn9kiwvtre90cXaNLkmadMWa1zQMs3XORCXNbsH/OewwbxC5ia9dCxIxnTAsSxXJaa/p5y8DlvJg==" + "version": "3.13.1", + "resolved": "https://registry.npmjs.org/type-fest/-/type-fest-3.13.1.tgz", + "integrity": "sha512-tLq3bSNx+xSpwvAJnzrK0Ep5CLNWjvFTOp71URMaAEWBfRb9nnJiBoUe0tF8bI4ZFO3omgBR6NvnbzVUT3Ly4g==" }, "typed-array-buffer": { "version": "1.0.3", diff --git a/packages/workbox-build/package.json b/packages/workbox-build/package.json index fa5c6691a..fbbcd02b1 100644 --- a/packages/workbox-build/package.json +++ b/packages/workbox-build/package.json @@ -26,7 +26,6 @@ "@apideck/better-ajv-errors": "^0.3.1", "@babel/core": "^7.24.4", "@babel/preset-env": "^7.11.0", - "@babel/runtime": "^7.27.1", "@rollup/plugin-babel": "^7.1.0", "@rollup/plugin-node-resolve": "^16.0.3", "@rollup/plugin-replace": "^6.0.3", @@ -44,6 +43,7 @@ "stringify-object": "^3.3.0", "strip-comments": "^2.0.1", "tempy": "^1.0.1", + "type-fest": "^3.13.1", "upath": "^1.2.0", "workbox-background-sync": "7.4.1", "workbox-broadcast-update": "7.4.1", diff --git a/packages/workbox-build/src/types.ts b/packages/workbox-build/src/types.ts index 5ed80319f..d0914ec6e 100644 --- a/packages/workbox-build/src/types.ts +++ b/packages/workbox-build/src/types.ts @@ -575,10 +575,10 @@ export type BuildType = 'dev' | 'prod'; /** * @private */ -export interface WorkboxPackageJSON extends PackageJson { +export type WorkboxPackageJSON = PackageJson & { workbox?: { browserNamespace?: string; packageType?: string; prodOnly?: boolean; }; -} +}; diff --git a/test/workbox-build/node/dependency-check.js b/test/workbox-build/node/dependency-check.js index 5f936e6ed..76f64c8f1 100644 --- a/test/workbox-build/node/dependency-check.js +++ b/test/workbox-build/node/dependency-check.js @@ -18,7 +18,6 @@ describe(`[workbox-build] Test Dependencies`, function () { ignoreDirs: ['test', 'build', 'demo'], ignoreMatches: [ '@babel/preset-env', - '@babel/runtime', 'type-fest', 'workbox-background-sync', 'workbox-broadcast-update', diff --git a/test/workbox-cli/node/dependency-check.js b/test/workbox-cli/node/dependency-check.js index 43de8286a..7a47497c9 100644 --- a/test/workbox-cli/node/dependency-check.js +++ b/test/workbox-cli/node/dependency-check.js @@ -16,7 +16,6 @@ describe(`[workbox-cli] package.json`, function () { upath.join(__dirname, '..', '..', '..', 'packages', 'workbox-cli'), { ignoreDirs: ['build'], - ignoreMatches: ['@babel/runtime'], }, (unusedDeps) => { if (unusedDeps.dependencies.length > 0) { diff --git a/test/workbox-webpack-plugin/node/dependency-check.js b/test/workbox-webpack-plugin/node/dependency-check.js index bbab0876d..2a9eb3f7c 100644 --- a/test/workbox-webpack-plugin/node/dependency-check.js +++ b/test/workbox-webpack-plugin/node/dependency-check.js @@ -23,7 +23,6 @@ describe(`[workbox-webpack-plugin] Test Dependencies`, function () { ), { ignoreDirs: ['test', 'build', 'demo'], - ignoreMatches: ['@babel/runtime'], }, (unusedDeps) => { if (unusedDeps.dependencies.length > 0) { From 52b5017a88061519bc6ff9f77a74add935779639 Mon Sep 17 00:00:00 2001 From: "D.Super" <6484766+SuperDJ@users.noreply.github.com> Date: Fri, 6 Nov 2026 10:46:21 +0100 Subject: [PATCH 2/3] Updated package locks --- .../src/schema/GenerateSWOptions.json | 12 ++++++------ .../src/schema/WebpackGenerateSWOptions.json | 12 ++++++------ packages/workbox-window/package-lock.json | 14 +------------- 3 files changed, 13 insertions(+), 25 deletions(-) diff --git a/packages/workbox-build/src/schema/GenerateSWOptions.json b/packages/workbox-build/src/schema/GenerateSWOptions.json index 610d4db14..3d37dfbd8 100644 --- a/packages/workbox-build/src/schema/GenerateSWOptions.json +++ b/packages/workbox-build/src/schema/GenerateSWOptions.json @@ -757,13 +757,13 @@ "byteLength": { "type": "number" }, - "__@toStringTag@569": { + "__@toStringTag@502": { "type": "string" } }, "additionalProperties": false, "required": [ - "__@toStringTag@569", + "__@toStringTag@502", "byteLength" ] }, @@ -803,18 +803,18 @@ "byteLength": { "type": "number" }, - "__@species@1063": { + "__@species@996": { "$ref": "#/definitions/SharedArrayBuffer" }, - "__@toStringTag@569": { + "__@toStringTag@502": { "type": "string", "const": "SharedArrayBuffer" } }, "additionalProperties": false, "required": [ - "__@species@1063", - "__@toStringTag@569", + "__@species@996", + "__@toStringTag@502", "byteLength" ] }, diff --git a/packages/workbox-build/src/schema/WebpackGenerateSWOptions.json b/packages/workbox-build/src/schema/WebpackGenerateSWOptions.json index a0916a9d1..4ddd2b50d 100644 --- a/packages/workbox-build/src/schema/WebpackGenerateSWOptions.json +++ b/packages/workbox-build/src/schema/WebpackGenerateSWOptions.json @@ -740,13 +740,13 @@ "byteLength": { "type": "number" }, - "__@toStringTag@569": { + "__@toStringTag@502": { "type": "string" } }, "additionalProperties": false, "required": [ - "__@toStringTag@569", + "__@toStringTag@502", "byteLength" ] }, @@ -786,18 +786,18 @@ "byteLength": { "type": "number" }, - "__@species@1063": { + "__@species@996": { "$ref": "#/definitions/SharedArrayBuffer" }, - "__@toStringTag@569": { + "__@toStringTag@502": { "type": "string", "const": "SharedArrayBuffer" } }, "additionalProperties": false, "required": [ - "__@species@1063", - "__@toStringTag@569", + "__@species@996", + "__@toStringTag@502", "byteLength" ] }, diff --git a/packages/workbox-window/package-lock.json b/packages/workbox-window/package-lock.json index 94f3722dc..f7f67dbb3 100644 --- a/packages/workbox-window/package-lock.json +++ b/packages/workbox-window/package-lock.json @@ -9,8 +9,7 @@ "version": "7.4.1", "license": "MIT", "dependencies": { - "@types/trusted-types": "^2.0.2", - "workbox-core": "7.4.1" + "@types/trusted-types": "^2.0.2" } }, "node_modules/@types/trusted-types": { @@ -18,12 +17,6 @@ "resolved": "https://registry.npmjs.org/@types/trusted-types/-/trusted-types-2.0.7.tgz", "integrity": "sha512-ScaPdn1dQczgbl0QFTeTOmVHFULt394XJgOQNoyVhZ6r2vLnMLJfBPd53SB52T/3G36VI1/g2MZaX0cwDuXsfw==", "license": "MIT" - }, - "node_modules/workbox-core": { - "version": "7.4.1", - "resolved": "https://registry.npmjs.org/workbox-core/-/workbox-core-7.4.1.tgz", - "integrity": "sha512-DT+vu46eh/2vRsSHTY4Xmc32Z1rr9PRlQUXr1Dx30ZuXRWwOsvZgGgcwxcasubQLQmbTNYZjv44LkBAQ4tT5tQ==", - "license": "MIT" } }, "dependencies": { @@ -31,11 +24,6 @@ "version": "2.0.7", "resolved": "https://registry.npmjs.org/@types/trusted-types/-/trusted-types-2.0.7.tgz", "integrity": "sha512-ScaPdn1dQczgbl0QFTeTOmVHFULt394XJgOQNoyVhZ6r2vLnMLJfBPd53SB52T/3G36VI1/g2MZaX0cwDuXsfw==" - }, - "workbox-core": { - "version": "7.4.1", - "resolved": "https://registry.npmjs.org/workbox-core/-/workbox-core-7.4.1.tgz", - "integrity": "sha512-DT+vu46eh/2vRsSHTY4Xmc32Z1rr9PRlQUXr1Dx30ZuXRWwOsvZgGgcwxcasubQLQmbTNYZjv44LkBAQ4tT5tQ==" } } } From 9b1730f21ecbd4cdfb57e51c6b192d4e80ae0a8b Mon Sep 17 00:00:00 2001 From: "D.Super" <6484766+SuperDJ@users.noreply.github.com> Date: Mon, 16 Nov 2026 10:40:11 +0100 Subject: [PATCH 3/3] Drop type-fest from workbox-build WorkboxPackageJSON extended type-fest's PackageJson, so the published build/types.d.ts resolved whatever type-fest a consumer had installed. From type-fest 3.0.0 on, PackageJson carries a JsonValue index signature that the optional fields don't satisfy, so consumers type checking with skipLibCheck: false get ~50 TS2411 errors (reported on PR #3600 for type-fest 3.0.0 through 5.10.0). Replace it with a local interface covering the fields workbox-build reads (version, dependencies, workbox), so the published types no longer depend on type-fest at all. Removes 1 dependency (type-fest@3.13.1) from workbox-build's lockfile (381 -> 380 packages). --- packages/workbox-build/package-lock.json | 18 ------------------ packages/workbox-build/package.json | 1 - packages/workbox-build/src/types.ts | 8 ++++---- test/workbox-build/node/dependency-check.js | 1 - 4 files changed, 4 insertions(+), 24 deletions(-) diff --git a/packages/workbox-build/package-lock.json b/packages/workbox-build/package-lock.json index 90fb49238..aa825dd0f 100644 --- a/packages/workbox-build/package-lock.json +++ b/packages/workbox-build/package-lock.json @@ -29,7 +29,6 @@ "stringify-object": "^3.3.0", "strip-comments": "^2.0.1", "tempy": "^1.0.1", - "type-fest": "^3.13.1", "upath": "^1.2.0" }, "devDependencies": { @@ -4967,18 +4966,6 @@ "node": ">=8.0" } }, - "node_modules/type-fest": { - "version": "3.13.1", - "resolved": "https://registry.npmjs.org/type-fest/-/type-fest-3.13.1.tgz", - "integrity": "sha512-tLq3bSNx+xSpwvAJnzrK0Ep5CLNWjvFTOp71URMaAEWBfRb9nnJiBoUe0tF8bI4ZFO3omgBR6NvnbzVUT3Ly4g==", - "license": "(MIT OR CC0-1.0)", - "engines": { - "node": ">=14.16" - }, - "funding": { - "url": "https://github.com/sponsors/sindresorhus" - } - }, "node_modules/typed-array-buffer": { "version": "1.0.3", "resolved": "https://registry.npmjs.org/typed-array-buffer/-/typed-array-buffer-1.0.3.tgz", @@ -8315,11 +8302,6 @@ "is-number": "^7.0.0" } }, - "type-fest": { - "version": "3.13.1", - "resolved": "https://registry.npmjs.org/type-fest/-/type-fest-3.13.1.tgz", - "integrity": "sha512-tLq3bSNx+xSpwvAJnzrK0Ep5CLNWjvFTOp71URMaAEWBfRb9nnJiBoUe0tF8bI4ZFO3omgBR6NvnbzVUT3Ly4g==" - }, "typed-array-buffer": { "version": "1.0.3", "resolved": "https://registry.npmjs.org/typed-array-buffer/-/typed-array-buffer-1.0.3.tgz", diff --git a/packages/workbox-build/package.json b/packages/workbox-build/package.json index fbbcd02b1..4a35c11eb 100644 --- a/packages/workbox-build/package.json +++ b/packages/workbox-build/package.json @@ -43,7 +43,6 @@ "stringify-object": "^3.3.0", "strip-comments": "^2.0.1", "tempy": "^1.0.1", - "type-fest": "^3.13.1", "upath": "^1.2.0", "workbox-background-sync": "7.4.1", "workbox-broadcast-update": "7.4.1", diff --git a/packages/workbox-build/src/types.ts b/packages/workbox-build/src/types.ts index d0914ec6e..c5e6b6eec 100644 --- a/packages/workbox-build/src/types.ts +++ b/packages/workbox-build/src/types.ts @@ -1,5 +1,3 @@ -import {PackageJson} from 'type-fest'; - import {BroadcastCacheUpdateOptions} from 'workbox-broadcast-update/BroadcastCacheUpdate'; import {GoogleAnalyticsInitializeOptions} from 'workbox-google-analytics/initialize'; import {HTTPMethod} from 'workbox-routing/utils/constants'; @@ -575,10 +573,12 @@ export type BuildType = 'dev' | 'prod'; /** * @private */ -export type WorkboxPackageJSON = PackageJson & { +export interface WorkboxPackageJSON { + version?: string; + dependencies?: Record