Skip to content

WebVTT to_string() method doesn't print an empty line between cues #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
estigma88 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WebVTT to_string() method doesn't print an empty line between cues #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,9 @@ impl fmt::Display for WebVtt {
// Write cues
for (i, cue) in self.cues.iter().enumerate() {
if i > 0 {
writeln!(f)?; // Empty line between cues
// Empty line between cues
writeln!(f)?;
writeln!(f)?;
}
write!(f, "{}", cue)?;
}
Expand Down Expand Up @@ -886,19 +888,31 @@ First subtitle"#;
vtt.header.description = Some("Test".to_string());
vtt.add_metadata("Language", "en");

let cue = VttCue {
let cue1 = VttCue {
identifier: None,
start: VttTimestamp::new(Duration::from_secs(1)),
end: VttTimestamp::new(Duration::from_secs(5)),
settings: None,
payload: "Test".to_string(),
};
vtt.add_cue(cue);
vtt.add_cue(cue1);

let cue2 = VttCue {
identifier: None,
start: VttTimestamp::new(Duration::from_secs(5)),
end: VttTimestamp::new(Duration::from_secs(9)),
settings: None,
payload: "Test".to_string(),
};
vtt.add_cue(cue2);

let expected = r#"WEBVTT Test
Language: en

00:00:01.000 --> 00:00:05.000
Test

00:00:05.000 --> 00:00:09.000
Test"#;

assert_eq!(vtt.to_string(), expected);
Expand Down