refactor: remove redundant TestContainers BOM from openespi-common (#45)

* refactor: remove redundant TestContainers BOM from openespi-common

  Spring Boot 3.5 dependency management already includes TestContainers BOM,
  making the explicit version declaration redundant.

  Verified with MySQL and PostgreSQL integration tests - all 21 tests pass.

  🤖 Generated with [Claude Code](https://claude.com/claude-code)

  Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

* fix: add SonarCloud Maven plugin to active plugins section

  The sonar-maven-plugin was only defined in <pluginManagement> but not
  in the active <plugins> section, causing CI/CD failures when running
  mvn sonar:sonar.

  Maven requires plugins to be in the active <plugins> section to be
  executable via the prefix:goal syntax.

  Fixes SonarCloud Analysis and SonarCloud PR Analysis CI/CD failures.

  🤖 Generated with [Claude Code](https://claude.com/claude-code)

  Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

* fix: use full Maven coordinates for SonarCloud plugin invocation

  Maven's plugin prefix resolver doesn't recognize 'sonar' prefix by default.
  Changed from 'mvn sonar:sonar' to 'mvn org.sonarsource.scanner.maven:sonar-maven-plugin:sonar'
  in both CI/CD and PR checks workflows.

  This ensures the plugin can be resolved without requiring additional Maven
  settings.xml configuration for plugin groups.

  Fixes "No plugin found for prefix 'sonar'" CI/CD error.

  🤖 Generated with [Claude Code](https://claude.com/claude-code)

  Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

Author: dfcoffin

.github/workflows/ci.yml

@@ -159,7 +159,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         run: |
-          mvn sonar:sonar \
+          mvn org.sonarsource.scanner.maven:sonar-maven-plugin:sonar \
             -Dsonar.projectKey=GreenButtonAlliance_OpenESPI-GreenButton-Java \
             -Dsonar.organization=greenbuttonalliance \
             -Dsonar.host.url=https://sonarcloud.io \

.github/workflows/pr-checks.yml

@@ -88,7 +88,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         run: |
-          mvn sonar:sonar \
+          mvn org.sonarsource.scanner.maven:sonar-maven-plugin:sonar \
             -Dsonar.projectKey=GreenButtonAlliance_OpenESPI-GreenButton-Java \
             -Dsonar.organization=greenbuttonalliance \
             -Dsonar.host.url=https://sonarcloud.io \

openespi-common/pom.xml

@@ -82,7 +82,6 @@
         <!-- Modern Dependencies for Spring Boot 3.5.0 -->
         <lombok.version>1.18.34</lombok.version>
         <mapstruct.version>1.6.0</mapstruct.version>
-        <testcontainers.version>1.20.1</testcontainers.version>
 
         <!-- Legacy support for compatibility -->
         <commons-lang.version>2.6</commons-lang.version>
@@ -296,20 +295,6 @@
         </repository>
     </repositories>
 
-    <!-- Dependency Management for version consistency -->
-    <dependencyManagement>
-        <dependencies>
-            <!-- Testcontainers BOM for version management -->
-            <dependency>
-                <groupId>org.testcontainers</groupId>
-                <artifactId>testcontainers-bom</artifactId>
-                <version>${testcontainers.version}</version>
-                <type>pom</type>
-                <scope>import</scope>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <!-- Spring Boot Starters for Common Library -->
         <dependency>

pom.xml

@@ -142,6 +142,12 @@
                     </execution>
                 </executions>
             </plugin>
+
+            <!-- SonarCloud Maven Plugin -->
+            <plugin>
+                <groupId>org.sonarsource.scanner.maven</groupId>
+                <artifactId>sonar-maven-plugin</artifactId>
+            </plugin>
         </plugins>
     </build>
 </project>