Skip to content

Conversation

@nilahdad
Copy link

MyMatrix

chambaz and others added 26 commits March 3, 2014 21:25
- use px value for $base-line-height as ms(1) no longer defaults to 26px like modular-scale v1 did
- resolves #219
Fixing all of the Modular Scale, Compass, and Sass version issues. Gumby...
If the unicode values are not quoted then they are escaped and treated as text instead of a single value.
I am using Gumby in a new project and while updating HTML elements such as radio buttons, check boxes, and select elements I found that multi selects were not part of the Gumby UI demo.  I checked the CSS files and found no styling other than '.picker select'.  Prefacing the <select> elements with the 'picker' class triggers Gumby's design updates to the select (making multi-selects appear like drop down selects) so instead I think a new class of 'multi-picker' could help and be used as the wrapper for multi-selects instead of 'picker'.

Select "Picker" Example:
<div class="picker">
    <select>
        <option value="#" disabled="">Favorite Dalek phrase...</option>
        <option>EXTERMINATE</option>
        <option>EXTERMINATE</option>
        <option>EXTERMINATE</option>
    </select>
</div>

Select "Multi-Picker" Example:
<div class="multi-picker">
    <select multiple="multiple">
        <option value="#" disabled="">Favorite Dalek phrase...</option>
        <option>EXTERMINATE</option>
        <option>EXTERMINATE</option>
        <option>EXTERMINATE</option>
    </select>
</div>

The proposed styles attempt to use many of the same styles already used in Gumby's UI for <select> differing only where needed such as background-image/color, padding, etc.
To go along with the .circle, .square, .disc classes for an un-ordered list a .blank option for those times where you want the list items to be indented but do not want a list-style applied.

This can also be added to the Gumby UI page with the other list examples:
<div class="four columns">
    <h4 class="lead">ul.blank</h4>
    <ul class="blank">
        <li>List item</li>
        <li>List item</li>
        <li>List item</li>
            <ul class="blank">
                <li>Nested item</li>
                <li>Nested item</li>
            </ul>
        <li>List item</li>
        <li>List item</li>
        <li>List item</li>
        <li>List item</li>
    </ul>
</div>
[Issue 179] Quote unicode values
Use svg instead of png to get better image quality
Add SASS sources to "main" entry in bower.json
Actually use the header-link-hover-color variable.
Adding a blank list option.
Adding <select multiple> styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants