More test updates and cleanup #2060
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test turned out to test the same thing as another test, so it can be removed now.
The ConfigurableCountingService class was only used prior to the current implementation of metering. The service was registered as 'counting'. To verify that the class was no longer in use I checked for the string "ConfigurableCountingService" to verify that the only import was in CoreModule.js. Then I searched for `'counting`, `"counting"` and `counting`, finding no matches where the service was being obtained from the registry. This is strong evidence that this code is no longer used anywhere. Additionally, this code should no longer be used anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.