Fix Browse button layout Round 2 #6365
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem** Browse button in Custom Object upload dialog displays weirdly in portrait mode on iOS. It unexpectedly covers almost the entire URL area in portrait mode. We applied a change to fix but it didn't work. **Changes** * Remove flax stuffs and width 60px from browse style * Add justify-content: end to IconButton style
keianhzo
approved these changes
Nov 13, 2023
Contributor
Author
|
@keianhzo Thanks for reviewing. Note that we may not merge this PR because we found that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up PR to #6361
Problem
Browse button in Custom Object upload dialog displays weirdly in portrait mode on iOS. It unexpectedly covers almost the entire URL area in portrait mode.
We applied a change #6361 to fix but it didn't work.
Changes