align dependencies so there isn't mixed versions of the ajv subdependency causing errors

[matthargett]

What?

aligns direct package upgrades so there isn't a conflict between uses of multiple versions of the ajv library.

Why?

in the giant dependency update branch, a user hit a problem with conflicting versions of ajv being used by subdepdendencies when running the 'npm run build' target:

18.78 [webpack-cli] Error: Unknown keyword formatMinimum
18.78     at get (/node_modules/schema-utils/node_modules/ajv-keywords/dist/index.js:25:15)

while the lockfile should prevent this, this can happen when people's build environment is using an older node_modules cache. the cleanest way to fix this for users without manual steps from them is to bump the ajv-referencing packages. with newer eslint and prettier, there are bug fixes where it finds latent problems they missed before. I haven't modified the rule configuration of either, and did the most reasonably minimal fixes for things like unused-variable in error handlers.

Examples

18.78 [webpack-cli] Error: Unknown keyword formatMinimum
18.78     at get (/node_modules/schema-utils/node_modules/ajv-keywords/dist/index.js:25:15)

How to test

npm run test in root and admin directories

should have zero effect on the web apps themselves, but I tested storybook and default hubs page locally just to be sure.

Documentation of functionality

no docs necessary for end users or maintainers.

Limitations

this aligns the easy packages that reference the conflicting ajv versions that aren't disruptive (e.g. requires accommodating ES modules).

Alternatives considered

I tried using override keys in package.json, but there are breaking changes in ajv 8.x that will cause eslint to break. upstream eslint maintainers appear to be aware of this as a challenge in their ecosystem.

Open questions

Additional details or related context

relates to #6549 , carves out a thin slice that should help reduce that PR a bit

[DougReeder]

After running npm ci, npm test in the root directory succeeds, but npm test in the admin directory gets the message:

> [email protected] lint:js
> eslint '*.js' 'src/**/*.js'


/Users/doug/git/hubs-compose/services/hubs/admin/src/admin.js
  210:3  error  ReactDOM.render is deprecated since React 18.0.0, use createRoot instead, see https://reactjs.org/link/switch-to-createroot  react/no-deprecated

✖ 1 problem (1 error, 0 warnings)

Then the build succeeds, and runs without any initially noticeable errors (https://hubs.hominidsoftware.com/v6tN9xi/treadmill-animals)

[DougReeder]

The code changes look good (aside from the noted sections) — more error trapping and better log messages are always good.

[matthargett]

After running npm ci, npm test in the root directory succeeds, but npm test in the admin directory gets the message:

> [email protected] lint:js

> eslint '*.js' 'src/**/*.js'





/Users/doug/git/hubs-compose/services/hubs/admin/src/admin.js

  210:3  error  ReactDOM.render is deprecated since React 18.0.0, use createRoot instead, see https://reactjs.org/link/switch-to-createroot  react/no-deprecated



✖ 1 problem (1 error, 0 warnings)

Interesting. Is it expected that 'npm test' would work before running 'npm ci'? in this case, it seems to use the node_modules in the base directory, and there was a newer React there. I've pushed a fix that aligns the React version in admin module with the base directory, and adjusts to the React 18 API change in the error message above.

[DougReeder]

Interesting. Is it expected that 'npm test' would work before running 'npm ci'?

That entirely depends on what npm test does. Usually, you expect to run npm ci before any other npm commands.

in this case, it seems to use the node_modules in the base directory, and there was a newer React there.

If I understand the docs correctly, this is not supposed to happen. Npm is parsimonious, but only within a single node_modules directory: https://docs.npmjs.com/cli/v9/configuring-npm/folders?v=true#cycles-conflicts-and-folder-parsimony

However, if there is no node_modules directory at all in admin, npm will just use the node_modules directory in the root directory.

[DougReeder]

The latest version passes the automated tests in the root directory. Unfortunately, it currently doesn't build for me:

=> ERROR [builder  8/13] RUN cd admin && npm ci --legacy-peer-deps && cd ..                                                    1.6s
------                                                                                                                               
...
1.576 npm ERR! code EUSAGE
1.578 npm ERR! 
1.578 npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
1.578 npm ERR! 
1.578 npm ERR! Invalid: lock file's [email protected] does not satisfy [email protected]

It looks like admin/package.json and admin/package-lock.json are not in sync. After running npm install in admin, npm test succeeds, but the build still fails:

 => ERROR [builder 11/13] RUN cd admin && npm run build 1> /dev/null && cp -R dist/* ../dist && cd ..                          83.9s 
------                                                                                                                               
 > [builder 11/13] RUN cd admin && npm run build 1> /dev/null && cp -R dist/* ../dist && cd ..:                                      
13.85 [BABEL] Note: The code generator has deoptimised the styling of /admin/node_modules/hubs/node_modules/hls.js/dist/hls.js as it exceeds the max of 500KB.                                                                                                            
------                                                                                                                               

 1 warning found (use docker --debug to expand):
 - JSONArgsRecommended: JSON arguments recommended for cmd to prevent unintended behavior related to OS signals (line 32)
Dockerfile:16
--------------------
  14 |     env BASE_ASSETS_PATH="{{rawhubs-base-assets-path}}"
  15 |     run npm run build
  16 | >>> run cd admin && npm run build 1> /dev/null && cp -R dist/* ../dist && cd ..
  17 |     run mkdir -p dist/pages && mv dist/*.html dist/pages && mv dist/hub.service.js dist/pages && mv dist/schema.toml dist/pages
  18 |     run mkdir /hubs/rawhubs && mv dist/pages /hubs/rawhubs && mv dist/assets /hubs/rawhubs && mv dist/favicon.ico /hubs/rawhubs/pages
--------------------
ERROR: failed to solve: process "/bin/sh -c cd admin && npm run build 1> /dev/null && cp -R dist/* ../dist && cd .." did not complete successfully: exit code: 1

Running npm run build in the admin directory, on my dev machine, also fails:

ERROR in ./src/admin.js 42:0-70
Module not found: Error: Can't resolve '@material-ui/core/styles' in '/Users/doug/git/hubs-compose/services/hubs/admin/src'

ERROR in ./src/react-components/account-edit-toolbar.js 11:0-54
Module not found: Error: Can't resolve '@material-ui/core/styles' in '/Users/doug/git/hubs-compose/services/hubs/admin/src/react-components'
 @ ./src/react-components/accounts.js 14:0-60 286:46-64
 @ ./src/admin.js 33:0-71 155:12-23 156:12-23

ERROR in ./src/react-components/account-edit-toolbar.js 12:0-46
Module not found: Error: Can't resolve '@material-ui/core/Button' in '/Users/doug/git/hubs-compose/services/hubs/admin/src/react-components'
 @ ./src/react-components/accounts.js 14:0-60 286:46-64
 @ ./src/admin.js 33:0-71 155:12-23 156:12-23
...

[DougReeder]

Ok! In this version, both sets of tests pass, it builds without errors, and a room can be entered, with no obvious problems!

https://hubs.hominidsoftware.com/v6tN9xi/treadmill-animals

[DougReeder]

With a little more smoke testing, I think we can merge this.

[DougReeder]

Ah, but this PR should be against the dev branch. I hope it will work the same.

[Exairnous]

@DougReeder Uh, the dev branch here is really old, I don't think we want anything based off of it. As far as I know the only repository that has/needs an active development branch is the hubs-cloud repository (although the hubs-discord-bot may need one too depending on how we decide to release it to the public). Unless there's something specific you wanted from the dev branch here? (I see it has diverged from master by six commits)

[DougReeder]

You’re right, I was confusing the hubs and hubs-cloud repos. Whew!Doug ***@***.*** Jun 28, 2025, at 1:11 AM, Exairnous ***@***.***> wrote:Exairnous left a comment (Hubs-Foundation/hubs#6559) @DougReeder Uh, the dev branch here is really old, I don't think we want anything based off of it. As far as I know the only repository that has/needs an active development branch is the hubs-cloud repository (although the hubs-discord-bot may need one too depending on how we decide to release it to the public). Unless there's something specific you wanted from the dev branch here? (I see it has diverged from master by six commits) —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[matthargett]

awesome. Merge when ready :)

[Exairnous]

I deployed this to my Community Edition instance (using the Custom Docker Build Push GitHub Action) and the main page/loading a room seems to work okay, but the admin screen errors out for me (Firefox 136.0.1 Linux) when I visit it and doesn't render (all I get is a white screen).
hubs-pr-6559-admin-error-log-2025-07-08.log

[Exairnous]

It looks to me like the problem could be that when the node version for admin was reverted back to 16 the changes to admin.js weren't reverted as well.

Note: this only the initial impression I got from looking at the code and recent commits, I haven't explored any further and haven't tested anything.

[DougReeder]

I also see the admin pages failing to load. The console problems start with a warning and an error:

SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data :1:145535

Error: Minified React error #321; visit https://reactjs.org/docs/error-decoder.html?invariant=321 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

[DougReeder]

The introduction of the new root API, ReactDOM.createRoot, is one of the most significant improvements in React 18.

If we have to stick with React 16 for now, we can't use createRoot. At least it appears to be used in only one place.

[Exairnous]

@matthargett The latest change still errors out for me :(

[Exairnous]

Text log.
hubs-pr-6559-admin-error-log-2025-07-13.log

[Exairnous]

The latest change works better, the admin screen loads now, but the table view (?) pages like "Pending scenes" don't display properly and give this error in a popup (nothing about it seems to be printed to the console):
t.queryParameters is not a function

[Exairnous]

@matthargett That fixed it on my end. Thanks! Everything seems to be functioning normally in the admin panel now. I still get the following error, but it doesn't seem to prevent anything from working (still, it would be nice to get rid of, if possible).

SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

[Exairnous]

@matthargett Ah, I just checked and that JSON syntax error is because of the console.warn you added to line 271 in admin/src/admin.js. That part of the code deals with ita schemas and Community Edition currently doesn't use ita (we don't have an ita instance set up), so it will always fail for the majority of people (but that's not actually a problem). Could you include a mention of ita in the error message so that it can be easily identified as something that (probably) doesn't need to be worried about? Maybe something like Warning: Couldn't get ita schema. with the actual error message following after that?

[Exairnous]

Just noticed there's also some linter errors reported by the test-and-deploy-storybook workflow:

/home/runner/work/hubs/hubs/admin/src/admin.js
Error:   48:25  error  Replace `'error',·(event)` with `"error",·event`                            prettier/prettier
Error:   60:25  error  Replace `'unhandledrejection',·(event)` with `"unhandledrejection",·event`  prettier/prettier
Error:   69:28  error  Replace `(props)` with `props`                                              prettier/prettier

✖ 3 problems (3 errors, 0 warnings)
  3 errors and 0 warnings potentially fixable with the `--fix` option.

Error: Process completed with exit code 1.

[DougReeder]

For me, the latest version load and runs a room properly, but the Admin page fails to load with these errors:

XHRGET
https://hubs.hominidsoftware.com/turkey/schemas
[HTTP/2 404 64ms]

SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data :1:145535
Source map error: Error: request failed with status 404
Stack in the worker:networkRequest@resource://devtools/client/shared/source-map-loader/utils/network-request.js:43:9

Resource URL: https://hubs.hominidsoftware.com/%3Canonymous%20code%3E
Source Map URL: installHook.js.map

Uncaught (in promise) TypeError: i.H is not a function

The last error is thrown by line 238 of admin.js, which is

const root = createRoot(container);

This is running in Firefox 140.0.4 under MacOS Sequoia 15.5

[matthargett]

Just noticed there's also some linter errors reported by the test-and-deploy-storybook workflow:

/home/runner/work/hubs/hubs/admin/src/admin.js
Error:   48:25  error  Replace `'error',·(event)` with `"error",·event`                            prettier/prettier
Error:   60:25  error  Replace `'unhandledrejection',·(event)` with `"unhandledrejection",·event`  prettier/prettier
Error:   69:28  error  Replace `(props)` with `props`                                              prettier/prettier

✖ 3 problems (3 errors, 0 warnings)
  3 errors and 0 warnings potentially fixable with the `--fix` option.

Error: Process completed with exit code 1.

this was fixed in the next push. I just verified lint is clean :)

[matthargett]

For me, the latest version load and runs a room properly, but the Admin page fails to load with these errors:

XHRGET https://hubs.hominidsoftware.com/turkey/schemas [HTTP/2 404 64ms]

SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data :1:145535 Source map error: Error: request failed with status 404 Stack in the worker:networkRequest@resource://devtools/client/shared/source-map-loader/utils/network-request.js:43:9

Resource URL: https://hubs.hominidsoftware.com/%3Canonymous%20code%3E Source Map URL: installHook.js.map

Uncaught (in promise) TypeError: i.H is not a function

The last error is thrown by line 238 of admin.js, which is

const root = createRoot(container);

This is running in Firefox 140.0.4 under MacOS Sequoia 15.5

that was with the latest code pulled? can you tell me the git commit hash at the top of git log?

[matthargett]

@matthargett Ah, I just checked and that JSON syntax error is because of the console.warn you added to line 271 in admin/src/admin.js. That part of the code deals with ita schemas and Community Edition currently doesn't use ita (we don't have an ita instance set up), so it will always fail for the majority of people (but that's not actually a problem). Could you include a mention of ita in the error message so that it can be easily identified as something that (probably) doesn't need to be worried about? Maybe something like Warning: Couldn't get ita schema. with the actual error message following after that?

fixed.

[DougReeder]

I tried building in a different copy of the repo, and now it appears to work fine. 😒

[matthargett]

Thanks for testing! Please merge when ready!

[Exairnous]

I think this is good.

A couple small nits I found:

reasonMessage showed the string of an object instead of the actual object when I simulated a network error, is this expected?

Unhandled Promise Rejection: 
Object { reasonMessage: "[object Event]", stack: undefined }
​
reasonMessage: "[object Event]"
​
stack: undefined
​
<prototype>: Object { … }
admin.js:61:10
    <anonymous> admin.js:61
    (Async: EventListener.handleEvent)
    <anonymous> admin.js:60
    <anonymous> admin.js:356
    <anonymous> admin.js:356

Also, I wasn't able to figure out how to trigger the "HTTP Error in data provider" to test the changes to it, but since it's already throwing an error it should be fine even if there were some issue.

[DougReeder]

Thanks for all your work! This was a real bear.

[DougReeder]

Thanks for all your hard work!