fix: Storage job sync fails when another job is running #8851
+85
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8851 +/- ##
============================================
+ Coverage 66.70% 80.91% +14.21%
============================================
Files 813 259 -554
Lines 63619 23438 -40181
Branches 10765 0 -10765
============================================
- Hits 42437 18965 -23472
+ Misses 21178 4473 -16705
+ Partials 4 0 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run a sync job and if you try to click Sync storage button again while the sync job is already running, clicking Sync storage caused a 500 with
ValueError: signal only works in main thread of the main interpreter. This happened because is_job_on_worker() used StartedJobRegistry.get_job_ids(), which internally runs registry cleanup using RQ’s “death penalty” (SIGALRM). When called from a Django request thread (not the main interpreter thread), that signal setup fails and bubbles up as a runtime error.The fix changes is_job_on_worker() to perform a read-only membership check directly in Redis using ZSCORE on the registry’s sorted set key, instead of calling get_job_ids(). Behavior is unchanged from the caller’s perspective (we still answer “is this job id currently started?”), but we no longer trigger any signal-based timeout logic in request threads, so storage sync works reliably without runtime errors.