Skip to content

Commit 2ad0b31

Browse files
fix: resolve Helm chart configuration validation errors (#1410)
* fix: resolve Helm chart configuration validation errors This commit fixes three configuration validation issues in the Helm chart introduced in PR #1400: 1. OBSERVABILITY_EXCLUDE_PATHS: Changed from comma-separated string to JSON array format to match Pydantic List[str] type expectations - Before: "/health,/healthz,/ready,/metrics,/static/.*" - After: '["\/health", "\/healthz", "\/ready", "\/metrics", "\/static\/.*"]' - Error fixed: json.decoder.JSONDecodeError and pydantic_settings.SettingsError 2. PLUGINS_CLI_MARKUP_MODE: Set default value to "rich" instead of empty string to satisfy Pydantic Literal type validation - Before: "" - After: "rich" - Valid options: "markdown", "rich", "disabled", or None - Error fixed: pydantic_core._pydantic_core.ValidationError 3. fast-time-server version: Updated to latest stable release - Before: "0.9.0" - After: "0.8.0" These changes prevent validation errors during application startup when deploying via Helm. Signed-off-by: ppippi <[email protected]> Signed-off-by: ppippi-dev <[email protected]> * 0.9.0 tag Signed-off-by: Mihai Criveti <[email protected]> --------- Signed-off-by: ppippi <[email protected]> Signed-off-by: ppippi-dev <[email protected]> Signed-off-by: Mihai Criveti <[email protected]> Co-authored-by: Mihai Criveti <[email protected]>
1 parent c7c1c94 commit 2ad0b31

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

charts/mcp-stack/values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ mcpContextForge:
305305
PLUGINS_MTLS_VERIFY: "true" # verify remote plugin certificates
306306
PLUGINS_MTLS_CHECK_HOSTNAME: "true" # enforce hostname verification when verifying certs
307307
PLUGINS_CLI_COMPLETION: "false" # enable auto-completion for plugins CLI
308-
PLUGINS_CLI_MARKUP_MODE: "" # set markup mode for plugins CLI
308+
PLUGINS_CLI_MARKUP_MODE: "rich" # set markup mode for plugins CLI (rich, markdown, or disabled)
309309

310310
# ─ OpenTelemetry Observability ─
311311
OTEL_ENABLE_OBSERVABILITY: "true" # master switch for observability
@@ -323,7 +323,7 @@ mcpContextForge:
323323
OBSERVABILITY_TRACE_RETENTION_DAYS: "7" # number of days to retain trace data
324324
OBSERVABILITY_MAX_TRACES: "100000" # maximum number of traces to retain
325325
OBSERVABILITY_SAMPLE_RATE: "1.0" # trace sampling rate (0.0-1.0, 1.0 = trace everything)
326-
OBSERVABILITY_EXCLUDE_PATHS: "/health,/healthz,/ready,/metrics,/static/.*" # paths to exclude from tracing
326+
OBSERVABILITY_EXCLUDE_PATHS: '["/health", "/healthz", "/ready", "/metrics", "/static/.*"]' # paths to exclude from tracing
327327
OBSERVABILITY_METRICS_ENABLED: "true" # enable metrics collection
328328
OBSERVABILITY_EVENTS_ENABLED: "true" # enable event logging within spans
329329

0 commit comments

Comments
 (0)