IcingaObjectHandler: Check for import loop detection during rest api updates

Author: raviks789

library/Director/RestApi/IcingaObjectHandler.php

@@ -13,6 +13,7 @@
 use Icinga\Module\Director\Objects\IcingaHost;
 use Icinga\Module\Director\Objects\IcingaObject;
 use Icinga\Module\Director\Resolver\OverrideHelper;
+use Icinga\Module\Director\Resolver\TemplateTree;
 use InvalidArgumentException;
 use RuntimeException;
 
@@ -139,6 +140,21 @@ protected function handleApiRequest()
                         ], $data);
                         $object->replaceWith(IcingaObject::createByType($type, $data, $db));
                     }
+
+                    if (in_array((int) $object->get('id'), $object->listAncestorIds())) {
+                        throw new RuntimeException(
+                            'Import loop detected for the object '
+                            . $object->getObjectName() . ' -> Imports: '
+                            . implode(', ', $object->getImports())
+                        );
+                    }
+
+                    if (in_array($object->get('object_name'), $data['imports'])) {
+                        throw new RuntimeException(
+                            'You can not import the same object into itself: ' . $object->getObjectName()
+                        );
+                    }
+
                     $this->persistChanges($object);
                     $this->sendJson($object->toPlainObject(false, true));
                 } elseif ($allowsOverrides && $type === 'service') {