Skip to content

Commit 6beac02

Browse files
committed
webkit-dev-ci-tools: Adapt recipe to the oelint-adv spectations
Changes in the recipe to fullfill the guide lines from oelint-adv. Maintenance-Type: linter
1 parent 85eb4d2 commit 6beac02

File tree

2 files changed

+24
-21
lines changed

2 files changed

+24
-21
lines changed
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
IMAGE_INSTALL:append = " \
22
apache2 \
33
apache2-scripts \
4-
"
4+
"
5+

recipes-browser/images/webkit-dev-ci-tools.bb

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1-
SUMMARY = "Image with all the required tools to build WPE (using the script build-webkit) \
2-
and also run the tests (layout-tests, performance-tests, api-tests, etc). \
3-
The SDK that gets build with 'bitbake ${IMAGENAME} -c populate_sdk' is valid \
4-
for using in the host with the script build-webkit and the image itself has \
5-
the tools to run the tests on the board. But the image doesn't contain \
6-
webkit (wpe) itself. The purpose of this image is for using on the \
7-
continous integration systems of webkit.org for WPE tests. \
8-
For more info see the WebKit script named cross-toolchain-helper."
1+
SUMMARY = "WPE continuous integration build and test image"
2+
DESCRIPTION = "Image with all the required tools to build WPE (using the script build-webkit) \
3+
and also run the tests (layout-tests, performance-tests, api-tests, etc). \
4+
The SDK that gets build with 'bitbake ${IMAGENAME} -c populate_sdk' is valid \
5+
for using in the host with the script build-webkit and the image itself has \
6+
the tools to run the tests on the board. But the image doesn't contain \
7+
webkit (wpe) itself. The purpose of this image is for using on the \
8+
continous integration systems of webkit.org for WPE tests. \
9+
For more info see the WebKit script named cross-toolchain-helper."
910

1011
LICENSE = "MIT"
1112

@@ -17,23 +18,25 @@ SDK_XZ_COMPRESSION_LEVEL ?= "-0"
1718

1819
# Use .xz instead of .bz2
1920
IMAGE_FSTYPES:append = " tar.xz wic.xz wic.bmap"
21+
# nooelint: oelint.vars.specific - ignored for convenience
2022
IMAGE_FSTYPES:remove:rpi = "tar.bz2 wic.bz2 ext3"
2123

2224
inherit core-image features_check
2325

2426
# Add 'dbg-pkgs' to this list or to EXTRA_IMAGE_FEATURES in local.conf if
2527
# you want debug symbols installed on the image. It is not added by default
2628
# because it increases the image size quite a bit (from 4GB to 10GB unpacked)
27-
IMAGE_FEATURES += " \
28-
debug-tweaks \
29-
dev-pkgs \
30-
hwcodecs \
31-
package-management \
32-
ssh-server-openssh \
33-
tools-debug \
34-
tools-profile \
35-
tools-sdk \
36-
"
29+
# nooelint: oelint.var.badimagefeature.debug-tweaks - This is an evaluation image
30+
IMAGE_FEATURES += "\
31+
debug-tweaks \
32+
dev-pkgs \
33+
hwcodecs \
34+
package-management \
35+
ssh-server-openssh \
36+
tools-debug \
37+
tools-profile \
38+
tools-sdk \
39+
"
3740
REQUIRED_DISTRO_FEATURES = "opengl wayland"
3841

3942
IMAGE_LINGUAS = "en-us es-es"
@@ -91,7 +94,7 @@ IMAGE_INSTALL:append = " \
9194
wayland-tools \
9295
"
9396

94-
# vcgencmd and related tools for the RPi (works also with opensource stack)
97+
# nooelint: oelint.vars.specific - vcgencmd and related tools for the RPi (works also with opensource stack)
9598
IMAGE_INSTALL:append:rpi = " userland"
9699

97100
SDK_NATIVE_TOOLS = " \
@@ -129,7 +132,6 @@ IMAGE_INSTALL:append = " ${@bb.utils.contains_any('DISTRO_FEATURES', 'x11 waylan
129132
IMAGE_INSTALL:append = " ${PREFERRED_PROVIDER_virtual/wpebackend}"
130133
IMAGE_INSTALL:append = " packagegroup-wpewebkit-depends"
131134

132-
133135
#
134136
# Set a valid internal-sftp
135137
#

0 commit comments

Comments
 (0)