You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Updated option count from 64 to 65 (new graphApi config)
- Added Graph API integration (PR #1958) to recent improvements
- Added graphApi to conditional options and good nested objects examples
- Referenced new MQTT enhancement research and ADRs (006, 007)
- Updated all line counts and totals throughout document
The graphApi option follows the same conditional pattern as
customNotification - only relevant when enabled, reinforcing finding #3
about not all implementations needing all features.
Copy file name to clipboardExpand all lines: docs-site/docs/development/research/configuration-organization-research.md
+9-6Lines changed: 9 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -7,12 +7,14 @@
7
7
## Executive Summary
8
8
9
9
### Current State
10
-
Teams for Linux has **64 active configuration options** managed through a flat yargs-based configuration system. While functional, the current organization has several issues: related options are scattered across documentation categories, naming conventions are inconsistent, and conditional options add complexity.
10
+
Teams for Linux has **65 active configuration options** managed through a flat yargs-based configuration system. While functional, the current organization has several issues: related options are scattered across documentation categories, naming conventions are inconsistent, and conditional options add complexity.
11
11
12
12
**Recent Improvements**:
13
13
- MQTT documentation added in PR [#1939](https://github.com/IsmaelMartinez/teams-for-linux/pull/1939)
14
14
- Deprecated options (`contextIsolation`, `sandbox`) removed from configuration
15
15
- Custom notification system added in PR [#1979](https://github.com/IsmaelMartinez/teams-for-linux/pull/1979) with new `customNotification` object config
16
+
- Graph API integration added in PR [#1958](https://github.com/IsmaelMartinez/teams-for-linux/pull/1958) with new `graphApi` object config
- Bad: `customBGServiceBaseUrl`, `customBGServiceConfigFetchInterval` (should be nested)
37
40
38
41
6.**Naming Issues**: Mix of negative (`disableNotifications`) and positive (`trayIconEnabled`) naming, plus some overly verbose names.
@@ -79,7 +82,7 @@ System Config → User Config → CLI Args → Defaults
79
82
- Immutable config pattern via AppConfiguration class
80
83
81
84
**Problem Areas:**
82
-
- All 64 active options defined in single ~525-line yargs config block
85
+
- All 65 active options defined in single ~530-line yargs config block
83
86
- No programmatic grouping (only documentation grouping)
84
87
- Mixed patterns (flat vs nested) without clear logic
85
88
@@ -137,7 +140,7 @@ mqtt // Now documented in PR #1939
137
140
// contextIsolation, sandbox - REMOVED from configuration
138
141
```
139
142
140
-
**Total Active Options: 64** (including new customNotification system)
143
+
**Total Active Options: 65** (including customNotification and graphApi systems)
141
144
142
145
### Problem Analysis
143
146
@@ -278,7 +281,7 @@ customBackground: {
278
281
- Removed `sandbox` option from app/config/index.js (was at lines 388-395)
279
282
- Both options were never actually used in the code (verified via grep)
280
283
- Users with these in their config.json will simply have them ignored (no breaking change)
281
-
- Total configuration options: 64 (after adding customNotification system)
284
+
- Total configuration options: 65 (after adding customNotification and graphApi systems)
282
285
283
286
**Original Issue** (now resolved):
284
287
These options were deprecated with warnings but still accepted values, cluttering the configuration without providing any functionality. They have now been cleanly removed.
@@ -1180,7 +1183,7 @@ function migrateConfig(config, configPath) {
1180
1183
### Phase 1 Success Criteria
1181
1184
-[x]~~MQTT configuration documented with examples~~ ✅ **COMPLETED** in PR [#1939](https://github.com/IsmaelMartinez/teams-for-linux/pull/1939)
0 commit comments