composeCompatibilityBrowserDistribution: Skip web targets where executable is not configures (#5394)

composeCompatibilityBrowserDistribution: Skip web targets where
executable is not configures

Fixes
https://youtrack.jetbrains.com/issue/CMP-8760/Compatibility-task-breaks-build-of-Compose-library-modules

## Testing
Manual and running `WebCompatibilityDistributionTest`

## Release Notes
N/A

Author: Schahen

gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/web/tasks/WebCompatibilityTask.kt

@@ -133,24 +133,20 @@ private fun Project.registerWebCompatibilityTask(mppPlugin: KotlinMultiplatformE
 
         mppPlugin.targets.withType(KotlinJsIrTarget::class.java).configureEach { target ->
             if (target.platformType == KotlinPlatformType.wasm) {
-                wasmOutputName.set(
-                    tasks.named(
-                        "${target.name}BrowserProductionWebpack",
-                        KotlinWebpack::class.java
-                    ).flatMap { it.mainOutputFileName }
-                )
+                tasks.withType(KotlinWebpack::class.java).findByName("${target.name}BrowserProductionWebpack")?.let {
+                    wasmOutputName.set(it.mainOutputFileName)
+                }
+
                 wasmDistFiles.from(
-                    tasks.named("${target.name}BrowserDistribution").map { it.outputs.files }
+                    tasks.matching { it.name == "${target.name}BrowserDistribution" }.map { it.outputs.files }
                 )
             } else if (target.platformType == KotlinPlatformType.js) {
-                jsOutputName.set(
-                    tasks.named(
-                        "${target.name}BrowserProductionWebpack",
-                        KotlinWebpack::class.java
-                    ).flatMap { it.mainOutputFileName }
-                )
+                tasks.withType(KotlinWebpack::class.java).findByName("${target.name}BrowserProductionWebpack")?.let {
+                    jsOutputName.set(it.mainOutputFileName)
+                }
+
                 jsDistFiles.from(
-                    tasks.named("${target.name}BrowserDistribution").map { it.outputs.files }
+                    tasks.matching { it.name == "${target.name}BrowserDistribution" }.map { it.outputs.files }
                 )
             }
 

gradle-plugins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/WebCompatibilityDistributionTest.kt

@@ -1,5 +1,6 @@
 package org.jetbrains.compose.test.tests.integration
 
+import org.jetbrains.compose.test.utils.ChecksWrapper
 import org.jetbrains.compose.test.utils.GradlePluginTestBase
 import org.jetbrains.compose.test.utils.TestProject
 import org.jetbrains.compose.test.utils.checkExists
@@ -33,26 +34,40 @@ class WebCompatibilityDistributionTest : GradlePluginTestBase() {
         }
     }
 
-    private fun runCompatibilityTest(
+    private fun runTaskAndCheck(projectPath: String, taskName: String, onExecution: ChecksWrapper.(project: TestProject) -> Unit) {
+        with(
+            testProject(
+                projectPath,
+                testEnvironment = defaultTestEnvironment.copy()
+            )
+        ) {
+            gradle(taskName).checks {
+                onExecution(this@with)
+            }
+        }
+    }
+
+    private fun assertSuccessfulCompatibilityRun(
         projectPath: String,
         successfulTasks: List<String>,
         distDir: String = defaultDistDir,
         expectedFiles: Set<String>
-    ) = with(
-        testProject(
-            projectPath,
-            testEnvironment = defaultTestEnvironment.copy()
-        )
     ) {
-        gradle(":composeApp:composeCompatibilityBrowserDistribution").checks {
+        runTaskAndCheck(projectPath, ":composeApp:composeCompatibilityBrowserDistribution") { testProject ->
             check.taskSuccessful(":composeApp:composeCompatibilityBrowserDistribution")
             successfulTasks.forEach { check.taskSuccessful(it) }
-            assertCompatibilityDistribution(dirPath = distDir, expectedFileNames = expectedFiles)
+            testProject.assertCompatibilityDistribution(dirPath = distDir, expectedFileNames = expectedFiles)
+        }
+    }
+
+    private fun assertSkippedCompatibilityRun(projectPath: String) {
+        runTaskAndCheck(projectPath, ":composeApp:composeCompatibilityBrowserDistribution") {
+            check.taskSkipped(":composeApp:composeCompatibilityBrowserDistribution")
         }
     }
 
     @Test
-    fun testWebJsWasm() = runCompatibilityTest(
+    fun testWebJsWasm() = assertSuccessfulCompatibilityRun(
         projectPath = "application/webJsWasm",
         successfulTasks = listOf(
             ":composeApp:jsBrowserDistribution",
@@ -71,7 +86,22 @@ class WebCompatibilityDistributionTest : GradlePluginTestBase() {
     )
 
     @Test
-    fun testWebJsWasmNonStandard() = runCompatibilityTest(
+    fun testWebJsOnly() = assertSkippedCompatibilityRun(
+        projectPath = "application/webJsOnly"
+    )
+
+    @Test
+    fun testWebWasmOnly() = assertSkippedCompatibilityRun(
+        projectPath = "application/webWasmOnly"
+    )
+
+    @Test
+    fun testWebJsNonExecutable() = assertSkippedCompatibilityRun(
+        projectPath = "application/webJsWasmNonExecutable"
+    )
+
+    @Test
+    fun testWebJsWasmNonStandard() = assertSuccessfulCompatibilityRun(
         projectPath = "application/webJsWasmNonStandard",
         successfulTasks = listOf(
             ":composeApp:webJsBrowserDistribution",
@@ -90,7 +120,7 @@ class WebCompatibilityDistributionTest : GradlePluginTestBase() {
     )
 
     @Test
-    fun testWebJsWasmReconfigured() = runCompatibilityTest(
+    fun testWebJsWasmReconfigured() = assertSuccessfulCompatibilityRun(
         projectPath = "application/webJsWasmReconfigured",
         successfulTasks = listOf(
             ":composeApp:wasmRepack",

gradle-plugins/compose/src/test/test-projects/application/webJsOnly/.yarnrc

@@ -0,0 +1 @@
+--install.mutex network

gradle-plugins/compose/src/test/test-projects/application/webJsOnly/build.gradle.kts

@@ -0,0 +1,7 @@
+plugins {
+    // this is necessary to avoid the plugins to be loaded multiple times
+    // in each subproject's classloader
+    id("org.jetbrains.kotlin.multiplatform") apply false
+    id("org.jetbrains.compose") apply false
+    id("org.jetbrains.kotlin.plugin.compose") apply false
+}

gradle-plugins/compose/src/test/test-projects/application/webJsOnly/composeApp/build.gradle.kts

@@ -0,0 +1,37 @@
+import org.jetbrains.kotlin.gradle.ExperimentalWasmDsl
+import org.jetbrains.kotlin.gradle.targets.js.webpack.KotlinWebpackConfig
+
+plugins {
+    id("org.jetbrains.kotlin.multiplatform")
+    id("org.jetbrains.compose")
+    id("org.jetbrains.kotlin.plugin.compose")
+}
+
+kotlin {
+    js(IR) {
+        outputModuleName.set("composeApp")
+        browser {
+            commonWebpackConfig {
+                outputFileName = "composeApp.js"
+            }
+        }
+        binaries.executable()
+    }
+
+    sourceSets {
+        commonMain.dependencies {
+            implementation(compose.runtime)
+        }
+
+        val webMain by creating {
+            resources.setSrcDirs(resources.srcDirs)
+            dependsOn(commonMain.get())
+        }
+
+        val jsMain by getting {
+            dependsOn(webMain)
+        }
+    }
+}
+
+

gradle-plugins/compose/src/test/test-projects/application/webJsOnly/composeApp/src/jsMain/kotlin/org/example/project/Platform.kt

@@ -0,0 +1,7 @@
+package org.example.project
+
+private class JsPlatform : Platform {
+    override val name: String = "Web with Kotlin/JS"
+}
+
+actual fun getPlatform(): Platform = JsPlatform()

gradle-plugins/compose/src/test/test-projects/application/webJsOnly/composeApp/src/wasmJsMain/kotlin/org/example/project/Platform.kt

@@ -0,0 +1,7 @@
+package org.example.project
+
+private class WasmPlatform : Platform {
+    override val name: String = "Web with Kotlin/Wasm"
+}
+
+actual fun getPlatform(): Platform = WasmPlatform()

gradle-plugins/compose/src/test/test-projects/application/webJsOnly/composeApp/src/webMain/kotlin/Greeting.kt

@@ -0,0 +1,9 @@
+package org.example.project
+
+class Greeting {
+    private val platform = getPlatform()
+
+    fun greet(): String {
+        return "Hello, ${platform.name}!"
+    }
+}

gradle-plugins/compose/src/test/test-projects/application/webJsOnly/composeApp/src/webMain/kotlin/Platform.kt

@@ -0,0 +1,7 @@
+package org.example.project
+
+interface Platform {
+    val name: String
+}
+
+expect fun getPlatform(): Platform

gradle-plugins/compose/src/test/test-projects/application/webJsOnly/composeApp/src/webMain/kotlin/main.kt

@@ -0,0 +1,5 @@
+package org.example.project
+
+fun main() {
+    println(Greeting().greet())
+}