Skip to content

Commit 9a513c5

Browse files
terrakokterrakok
authored
[gradle] Fix resource accessor name escaping. (#4901)
Fixes #4548 ## Testing Add compose resources with name such as "package", "is" or "item_$xxx" and check that app compiles and works fine. Accessors should be properly escaped ## Release Notes ### Fixes - Resources - Fix resource accessors escaping. Now it is possible to use resources with names: "package", "is", "item_$xxx" etc
1 parent 1bc3d1a commit 9a513c5

File tree

8 files changed

+102
-11
lines changed

8 files changed

+102
-11
lines changed

‎gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/resources/GeneratedResClassSpec.kt‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ private fun getChunkFileSpec(
240240
typeObject.addModifiers(KModifier.PRIVATE)
241241
val properties = idToResources.keys.map { resName ->
242242
PropertySpec.builder(resName, type.getClassName())
243-
.delegate("\nlazy·{ init_$resName() }")
243+
.delegate("\nlazy·{ %N() }", "init_$resName")
244244
.build()
245245
}
246246
typeObject.addProperties(properties)
@@ -250,7 +250,7 @@ private fun getChunkFileSpec(
250250
idToResources.forEach { (resName, items) ->
251251
val accessor = PropertySpec.builder(resName, type.getClassName(), resModifier)
252252
.receiver(ClassName(packageName, "Res", type.accessorName))
253-
.getter(FunSpec.getterBuilder().addStatement("return $chunkClassName.$resName").build())
253+
.getter(FunSpec.getterBuilder().addStatement("return $chunkClassName.%N", resName).build())
254254
.build()
255255
chunkFile.addProperty(accessor)
256256

@@ -260,8 +260,8 @@ private fun getChunkFileSpec(
260260
.addStatement(
261261
CodeBlock.builder()
262262
.add("return %T(\n", type.getClassName()).withIndent {
263-
add("\"${type}:${resName}\",")
264-
if (type.requiresKeyName()) add(" \"$resName\",")
263+
add("%S,", "$type:$resName")
264+
if (type.requiresKeyName()) add(" %S,", resName)
265265
withIndent {
266266
add("\nsetOf(\n").withIndent {
267267
items.forEach { item ->

‎gradle-plugins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/ResourcesTest.kt‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,9 +227,7 @@ class ResourcesTest : GradlePluginTestBase() {
227227

228228
@Test
229229
fun testMultiModuleResources() {
230-
val environment = defaultTestEnvironment.copy(
231-
kotlinVersion = "2.0.0-RC2"
232-
)
230+
val environment = defaultTestEnvironment.copy(kotlinVersion = "2.0.0")
233231
with(
234232
testProject("misc/kmpResourcePublication", environment)
235233
) {

‎gradle-plugins/compose/src/test/test-projects/misc/commonResources/expected-open-res/commonMainResourceAccessors/my/lib/res/Drawable0.commonMain.kt‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ private object CommonMainDrawable0 {
1212
public val camelCaseName: DrawableResource by
1313
lazy { init_camelCaseName() }
1414

15+
public val `is`: DrawableResource by
16+
lazy { init_is() }
17+
1518
public val vector: DrawableResource by
1619
lazy { init_vector() }
1720

@@ -41,6 +44,16 @@ private fun init_camelCaseName(): DrawableResource =
4144
)
4245
)
4346

47+
public val Res.drawable.`is`: DrawableResource
48+
get() = CommonMainDrawable0.`is`
49+
50+
private fun init_is(): DrawableResource = org.jetbrains.compose.resources.DrawableResource(
51+
"drawable:is",
52+
setOf(
53+
org.jetbrains.compose.resources.ResourceItem(setOf(), "drawable/is.xml", -1, -1),
54+
)
55+
)
56+
4457
public val Res.drawable.vector: DrawableResource
4558
get() = CommonMainDrawable0.vector
4659

‎gradle-plugins/compose/src/test/test-projects/misc/commonResources/expected-open-res/commonMainResourceAccessors/my/lib/res/String0.commonMain.kt‎

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ private object CommonMainString0 {
2121
public val hello: StringResource by
2222
lazy { init_hello() }
2323

24+
public val `info_using_release_$x`: StringResource by
25+
lazy { `init_info_using_release_$x`() }
26+
2427
public val multi_line: StringResource by
2528
lazy { init_multi_line() }
2629

@@ -83,13 +86,25 @@ private fun init_hello(): StringResource = org.jetbrains.compose.resources.Strin
8386
)
8487
)
8588

89+
public val Res.string.`info_using_release_$x`: StringResource
90+
get() = CommonMainString0.`info_using_release_$x`
91+
92+
private fun `init_info_using_release_$x`(): StringResource =
93+
org.jetbrains.compose.resources.StringResource(
94+
"string:info_using_release_${'$'}x", "info_using_release_${'$'}x",
95+
setOf(
96+
org.jetbrains.compose.resources.ResourceItem(setOf(), "values/strings.commonMain.cvr", 320,
97+
57),
98+
)
99+
)
100+
86101
public val Res.string.multi_line: StringResource
87102
get() = CommonMainString0.multi_line
88103

89104
private fun init_multi_line(): StringResource = org.jetbrains.compose.resources.StringResource(
90105
"string:multi_line", "multi_line",
91106
setOf(
92-
org.jetbrains.compose.resources.ResourceItem(setOf(), "values/strings.commonMain.cvr", 320,
107+
org.jetbrains.compose.resources.ResourceItem(setOf(), "values/strings.commonMain.cvr", 378,
93108
178),
94109
)
95110
)
@@ -100,7 +115,7 @@ public val Res.string.str_template: StringResource
100115
private fun init_str_template(): StringResource = org.jetbrains.compose.resources.StringResource(
101116
"string:str_template", "str_template",
102117
setOf(
103-
org.jetbrains.compose.resources.ResourceItem(setOf(), "values/strings.commonMain.cvr", 499,
118+
org.jetbrains.compose.resources.ResourceItem(setOf(), "values/strings.commonMain.cvr", 557,
104119
76),
105120
)
106121
)

‎gradle-plugins/compose/src/test/test-projects/misc/commonResources/expected/commonMainResourceAccessors/app/group/resources_test/generated/resources/Drawable0.commonMain.kt‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ private object CommonMainDrawable0 {
1212
public val camelCaseName: DrawableResource by
1313
lazy { init_camelCaseName() }
1414

15+
public val `is`: DrawableResource by
16+
lazy { init_is() }
17+
1518
public val vector: DrawableResource by
1619
lazy { init_vector() }
1720

@@ -41,6 +44,16 @@ private fun init_camelCaseName(): DrawableResource =
4144
)
4245
)
4346

47+
internal val Res.drawable.`is`: DrawableResource
48+
get() = CommonMainDrawable0.`is`
49+
50+
private fun init_is(): DrawableResource = org.jetbrains.compose.resources.DrawableResource(
51+
"drawable:is",
52+
setOf(
53+
org.jetbrains.compose.resources.ResourceItem(setOf(), "drawable/is.xml", -1, -1),
54+
)
55+
)
56+
4457
internal val Res.drawable.vector: DrawableResource
4558
get() = CommonMainDrawable0.vector
4659

‎gradle-plugins/compose/src/test/test-projects/misc/commonResources/expected/commonMainResourceAccessors/app/group/resources_test/generated/resources/String0.commonMain.kt‎

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ private object CommonMainString0 {
2121
public val hello: StringResource by
2222
lazy { init_hello() }
2323

24+
public val `info_using_release_$x`: StringResource by
25+
lazy { `init_info_using_release_$x`() }
26+
2427
public val multi_line: StringResource by
2528
lazy { init_multi_line() }
2629

@@ -83,13 +86,25 @@ private fun init_hello(): StringResource = org.jetbrains.compose.resources.Strin
8386
)
8487
)
8588

89+
internal val Res.string.`info_using_release_$x`: StringResource
90+
get() = CommonMainString0.`info_using_release_$x`
91+
92+
private fun `init_info_using_release_$x`(): StringResource =
93+
org.jetbrains.compose.resources.StringResource(
94+
"string:info_using_release_${'$'}x", "info_using_release_${'$'}x",
95+
setOf(
96+
org.jetbrains.compose.resources.ResourceItem(setOf(), "values/strings.commonMain.cvr", 320,
97+
57),
98+
)
99+
)
100+
86101
internal val Res.string.multi_line: StringResource
87102
get() = CommonMainString0.multi_line
88103

89104
private fun init_multi_line(): StringResource = org.jetbrains.compose.resources.StringResource(
90105
"string:multi_line", "multi_line",
91106
setOf(
92-
org.jetbrains.compose.resources.ResourceItem(setOf(), "values/strings.commonMain.cvr", 320,
107+
org.jetbrains.compose.resources.ResourceItem(setOf(), "values/strings.commonMain.cvr", 378,
93108
178),
94109
)
95110
)
@@ -100,7 +115,7 @@ internal val Res.string.str_template: StringResource
100115
private fun init_str_template(): StringResource = org.jetbrains.compose.resources.StringResource(
101116
"string:str_template", "str_template",
102117
setOf(
103-
org.jetbrains.compose.resources.ResourceItem(setOf(), "values/strings.commonMain.cvr", 499,
118+
org.jetbrains.compose.resources.ResourceItem(setOf(), "values/strings.commonMain.cvr", 557,
104119
76),
105120
)
106121
)

‎gradle-plugins/compose/src/test/test-projects/misc/commonResources/src/commonMain/composeResources/drawable/is.xml‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
<vector xmlns:android="http://schemas.android.com/apk/res/android"
2+
android:width="600dp"
3+
android:height="600dp"
4+
android:viewportWidth="600"
5+
android:viewportHeight="600">
6+
<path
7+
android:pathData="M301.21,418.53C300.97,418.54 300.73,418.56 300.49,418.56C297.09,418.59 293.74,417.72 290.79,416.05L222.6,377.54C220.63,376.43 219,374.82 217.85,372.88C216.7,370.94 216.09,368.73 216.07,366.47L216.07,288.16C216.06,287.32 216.09,286.49 216.17,285.67C216.38,283.54 216.91,281.5 217.71,279.6L199.29,268.27L177.74,256.19C175.72,260.43 174.73,265.23 174.78,270.22L174.79,387.05C174.85,393.89 178.57,400.2 184.53,403.56L286.26,461.02C290.67,463.51 295.66,464.8 300.73,464.76C300.91,464.76 301.09,464.74 301.27,464.74C301.24,449.84 301.22,439.23 301.22,439.23L301.21,418.53Z"
8+
android:fillColor="#041619"
9+
android:fillType="nonZero"/>
10+
<path
11+
android:pathData="M409.45,242.91L312.64,188.23C303.64,183.15 292.58,183.26 283.68,188.51L187.92,245C183.31,247.73 179.93,251.62 177.75,256.17L177.74,256.19L199.29,268.27L217.71,279.6C217.83,279.32 217.92,279.02 218.05,278.74C218.24,278.36 218.43,277.98 218.64,277.62C219.06,276.88 219.52,276.18 220.04,275.51C221.37,273.8 223.01,272.35 224.87,271.25L289.06,233.39C290.42,232.59 291.87,231.96 293.39,231.51C295.53,230.87 297.77,230.6 300,230.72C302.98,230.88 305.88,231.73 308.47,233.2L373.37,269.85C375.54,271.08 377.49,272.68 379.13,274.57C379.68,275.19 380.18,275.85 380.65,276.53C380.86,276.84 381.05,277.15 381.24,277.47L397.79,266.39L420.34,252.93L420.31,252.88C417.55,248.8 413.77,245.35 409.45,242.91Z"
12+
android:fillColor="#37BF6E"
13+
android:fillType="nonZero"/>
14+
<path
15+
android:pathData="M381.24,277.47C381.51,277.92 381.77,278.38 382.01,278.84C382.21,279.24 382.39,279.65 382.57,280.06C382.91,280.88 383.19,281.73 383.41,282.59C383.74,283.88 383.92,285.21 383.93,286.57L383.93,361.1C383.96,363.95 383.35,366.77 382.16,369.36C381.93,369.86 381.69,370.35 381.42,370.83C379.75,373.79 377.32,376.27 374.39,378L310.2,415.87C307.47,417.48 304.38,418.39 301.21,418.53L301.22,439.23C301.22,439.23 301.24,449.84 301.27,464.74C306.1,464.61 310.91,463.3 315.21,460.75L410.98,404.25C419.88,399 425.31,389.37 425.22,379.03L425.22,267.85C425.17,262.48 423.34,257.34 420.34,252.93L397.79,266.39L381.24,277.47Z"
16+
android:fillColor="#3870B2"
17+
android:fillType="nonZero"/>
18+
<path
19+
android:pathData="M177.75,256.17C179.93,251.62 183.31,247.73 187.92,245L283.68,188.51C292.58,183.26 303.64,183.15 312.64,188.23L409.45,242.91C413.77,245.35 417.55,248.8 420.31,252.88L420.34,252.93L498.59,206.19C494.03,199.46 487.79,193.78 480.67,189.75L320.86,99.49C306.01,91.1 287.75,91.27 273.07,99.95L114.99,193.2C107.39,197.69 101.81,204.11 98.21,211.63L177.74,256.19L177.75,256.17ZM301.27,464.74C301.09,464.74 300.91,464.76 300.73,464.76C295.66,464.8 290.67,463.51 286.26,461.02L184.53,403.56C178.57,400.2 174.85,393.89 174.79,387.05L174.78,270.22C174.73,265.23 175.72,260.43 177.74,256.19L98.21,211.63C94.86,218.63 93.23,226.58 93.31,234.82L93.31,427.67C93.42,438.97 99.54,449.37 109.4,454.92L277.31,549.77C284.6,553.88 292.84,556.01 301.2,555.94L301.2,555.8C301.39,543.78 301.33,495.26 301.27,464.74Z"
20+
android:strokeWidth="10"
21+
android:fillColor="#00000000"
22+
android:strokeColor="#083042"
23+
android:fillType="nonZero"/>
24+
<path
25+
android:pathData="M498.59,206.19L420.34,252.93C423.34,257.34 425.17,262.48 425.22,267.85L425.22,379.03C425.31,389.37 419.88,399 410.98,404.25L315.21,460.75C310.91,463.3 306.1,464.61 301.27,464.74C301.33,495.26 301.39,543.78 301.2,555.8L301.2,555.94C309.48,555.87 317.74,553.68 325.11,549.32L483.18,456.06C497.87,447.39 506.85,431.49 506.69,414.43L506.69,230.91C506.6,222.02 503.57,213.5 498.59,206.19Z"
26+
android:strokeWidth="10"
27+
android:fillColor="#00000000"
28+
android:strokeColor="#083042"
29+
android:fillType="nonZero"/>
30+
<path
31+
android:pathData="M301.2,555.94C292.84,556.01 284.6,553.88 277.31,549.76L109.4,454.92C99.54,449.37 93.42,438.97 93.31,427.67L93.31,234.82C93.23,226.58 94.86,218.63 98.21,211.63C101.81,204.11 107.39,197.69 114.99,193.2L273.07,99.95C287.75,91.27 306.01,91.1 320.86,99.49L480.67,189.75C487.79,193.78 494.03,199.46 498.59,206.19C503.57,213.5 506.6,222.02 506.69,230.91L506.69,414.43C506.85,431.49 497.87,447.39 483.18,456.06L325.11,549.32C317.74,553.68 309.48,555.87 301.2,555.94Z"
32+
android:strokeWidth="10"
33+
android:fillColor="#00000000"
34+
android:strokeColor="#083042"
35+
android:fillType="nonZero"/>
36+
</vector>

‎gradle-plugins/compose/src/test/test-projects/misc/commonResources/src/commonMain/composeResources/values/strings.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<string name="PascalCase">PascalCase</string>
99
<string name="1-kebab-case">1-kebab-case</string>
1010
<string name="camelCase">camelCase</string>
11+
<string name="info_using_release_$x">info_using_release_$x</string>
1112

1213
<plurals name="numberOfSongsAvailable">
1314
<item quantity="zero">%d zero</item>

0 commit comments

Comments
 (0)