Revert "one approach"

This reverts commit 1ca1779.

Author: chbndrhnns

python/helpers/pycharm/teamcity/pytest_plugin.py

@@ -168,33 +168,6 @@ def format_location(self, location):
             return "%s:%s (%s)" % (str(location[0]), str(location[1]), str(location[2]))
         return str(location)
 
-    def _extract_short_message(self, report):
-        """Best-effort extraction of a short, user-meaningful failure message.
-        Prefers pytest's reprcrash.message; falls back to the first non-empty
-        line of the stringified long representation.
-        """
-        try:
-            longrepr = getattr(report, 'longrepr', None)
-            # Prefer reprcrash.message when available (pytest longrepr objects)
-            reprcrash = getattr(longrepr, 'reprcrash', None)
-            msg = getattr(reprcrash, 'message', None) if reprcrash is not None else None
-            if msg:
-                return str(msg)
-        except Exception:
-            pass
-
-        # Fallback: first non-empty line from the longrepr text
-        try:
-            text = getattr(report, 'longrepr', '')
-            for line in text.splitlines():
-                s = line.strip()
-                if s:
-                    return s
-        except Exception:
-            pass
-
-        return None
-
     def pytest_sessionfinish(self, session, exitstatus):
         if exitstatus > pytest.ExitCode.TESTS_FAILED and self.current_test_item:
             test_id = self.format_test_id(self.current_test_item.nodeid, self.current_test_item.location)
@@ -268,11 +241,8 @@ def report_test_failure(self, test_id, report, message=None, report_output=True)
         else:
             duration = None
 
-        # Compute a concise display message which we pass separately from details
-        short_msg = self._extract_short_message(report)
         if message is None:
             message = self.format_location(report.location)
-        display_message = short_msg or message
 
         self.ensure_test_start_reported(test_id)
         if report_output:
@@ -317,12 +287,12 @@ def report_test_failure(self, test_id, report, message=None, report_output=True)
                 strace = strace[0:strace.index(data_postfix)].strip()
                 if strace.endswith(":") and diff_error.real_exception:
                     strace += " " + type(diff_error.real_exception).__name__
-            self.teamcity.testFailed(test_id, diff_error.msg or display_message, strace,
+            self.teamcity.testFailed(test_id, diff_error.msg or message, strace,
                                      flowId=test_id,
                                      comparison_failure=diff_error
                                      )
         else:
-            self.teamcity.testFailed(test_id, display_message, str(report.longrepr), flowId=test_id)
+            self.teamcity.testFailed(test_id, message, str(report.longrepr), flowId=test_id)
         self.report_test_finished(test_id, duration)
 
     def report_test_skip(self, test_id, report):