Can't set dns-nameservers in case of dhcp mode

[wizdear]

Thank you for your awesome scripts.
But, your script doesn't work as I thought.

Both static and dhcp can have dns-nameservers.
But below example command didn't working.
awk -f changeInterface.awk /etc/network/interfaces dev=eth0 mode=dhcp dns=210.220.163.82

I think that in case of dhcp, your script didn't set dns.

[6lv1-blr]

Here is my correction to add and/or keep extra parameters to DHCP mode

function writeDHCPFiels(device, fields, orders) {

    delete fields["netmask"];
	delete fields["address"];
	delete fields["gateway"];
	

    # Create the order as original
    for (o = 0; o in orders; o++) {
        field = orders[o];
        value = fields[field];
        delete fields[field];
        if (length(value))
            printf("    %s %s\n", field, value);
    }

    # additional items have no order
    for (f in fields) {
        value = fields[f];
        if (length(value))
            printf("    %s %s\n", f, value);
    }
}

function writeStatic(device, fields, orders) {

    # Create the order as original
    for (o = 0; o in orders; o++) {
        field = orders[o];
        value = fields[field];
        delete fields[field];
        if (length(value))
            printf("    %s %s\n", field, value);
    }

    # additional items have no order
    for (f in fields) {
        value = fields[f];
        if (length(value))
            printf("    %s %s\n", f, value);
    }
}

function usage() {
    print "awk -f changeInterfaces.awk <interfaces file> dev=<eth device> \n" \
          "       [mode=dhcp|static|manual] [action=add|remove] \n" \
          "       [address=<ip addr> networkmask=<ipaddress> <name=value> ]\n" \
          "       [arg=debug]\n"
}

BEGIN {

    start = 0;
    order = 0
    version = "inet"

    if (ARGC < 3 || ARGC > 10) {
        usage();
        exit 1;
    }

    for (i = 2; i < ARGC; i++) {
        num = split(ARGV[i], pair, "=");
        if (pair[1] == "arg" && pair[2] == "debug")
            debug = 1;
        else if (pair[1] == "mode")
            mode = pair[2];
        else if (pair[1] == "action" && pair[2] == "remove")
            remove = 1;
        else if (pair[1] == "action" && pair[2] == "add")
            add = 1;
        else if (pair[1] == "version" && pair[2] == "ipv6")
            version = "inet6";
        else if (pair[1] == "device" || pair[1] == "dev")
            device = pair[2];
        else if (num == 2) {
            if (pair[1] == "dns")
                pair[1] = "dns-nameservers";
            settings[pair[1]] = pair[2];
        }
        else {
            usage();
            exit 1;
        }
    }

    # Sort out the logic of argument
    if (mode == "dhcp" && (length(network) || length(gateway) || length(address) || length(netmask))) {
        print "Both DHCP and static properties are defined";
        usage();
        exit 1;
    }
    else if (!mode && !remove) {
        print "Missing mode input";
        usage();
        exit 1;
    }

    if (debug) {
        for (f in settings) {
            print f, ": ", settings[f];
        }
    }
}

{
    # auto <device> line
    if ($1 == "auto" || $1 == "allow-hotplug") {
        if ($2 != device) {
            # We come to different device
            # Good place to write all the settings
            if (targetDev) {
                targetDev = 0;
                if (!add && !remove) {
                    if (mode == "static" || mode == "manual")
                        writeStatic(device, settings, fieldOrders);
                    print "";
                }
            }
            print $0;
            next;
        }
        else if (!remove) {
            print $0;
            add = 0;
            next;
        }
        # Remove - don't print
        next;
    }
    # iface <device> .. line
    else if ($1 == "iface") {

        if ($2 != device) {
            # We come to different device
            # Good place to write all the settings
            if (targetDev) {
                targetDev = 0;
                if (!add && !remove) {
                    if (mode == "static" || mode == "manual")
                        writeStatic(device, settings, fieldOrders);
                    print "";
                }
            }
            print $0;
            next;
        }
        else {
            # If already specified 'add' and found an existing entry
            # cancel it
            add = 0;

            # Go to different condition in next loop
            targetDev = 1;

            if (!remove)
                printf("iface %s %s %s\n", device, version, mode);
            next;
        }
    }
    # Matched device found - working through each line
    # until found a 'auto' line or end of file
    else if (targetDev) {

        # Comment line - leave it
        if (substr($1, 0, 1) == "#") {
            print $0;
            next;
        }

        field = $1;
        if (field in settings) {
            # It means we specify the argument in command line
            # as preference over the file content
        }
        else {
            # field not in the command line
            # copy it over
            settings[field] = substr($0, index($0, $2))
        }
        fieldOrders[order] = field
        order++;
        next;

        # Other type of lines e.g. comment
    }
    else {
        print $0;
        next;
    }
}

END {
    # Come to the last line and we may not print out the
    # matched device settings
    if (!remove) {
        if (add || targetDev) {
            if (add) {
                printf("auto %s\n", device);
                printf("iface %s %s %s\n", device, version, mode);
            }
            if (mode != "dhcp")
                writeStatic(device, settings, fieldOrders);
            else
				writeDHCPFiels(device, settings, fieldOrders);
			print "";
        }
    }
}