Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 94.65% 94.70% +0.04%
==========================================
Files 13 13
Lines 318 321 +3
==========================================
+ Hits 301 304 +3
Misses 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Intel macOS job fails during Julia setup because
macos-latestselects an ARM runner. The JET job fails because JET 0.12 requires a module argument; correcting that call exposes an invalidInterruptException(nothing, cause)constructor path when an unfinished process is interrupted without an active caller.This change:
macos-15-intelfor x64 and adds Julia 1.11/1.12 to the existing 1.10/latest-stable Linux matrix with both thread counts;ConcurrentSimmodule to JET, preserving compatibility with older JET releases;ArgumentErrorbefore changing the event queue. Tests cover rejection before initialization and while suspended, normal completion, and valid caller/cause delivery. Documentation and changelog describe the requirement.Latest stable now covers Julia 1.13. Completed-process behavior is preserved.
Validation completed on Linux x86_64:
@test_brokenremains.allow_reresolve=false.git diff --checkpassed.At head
fc3352f, hosted checks also completed: full Linux/macOS/Windows/docs CI, JET/alpha, downgrade, changelog, and spelling all passed. Intel macOS and Windows logs confirm Julia 1.13.0.The sole remaining check failure is the pre-existing missing benchmark suite repaired in #166. Its target-triggered workflow reads the suite from master, so that check recovers once #166 is merged.