Repository navigation
Record a failing @test_logs as a failure instead of erroring - #64
Merged
JamesWrigley merged 3 commits intoSep 11, 2026
Merged
Conversation
A failing @test_logs produces a Test.LogTestFailure, which is not a Fail/Error/Broken, so ReTestSet has no record method for it and the failure throws a MethodError instead of being reported. Convert it to a Fail in record, as Test.DefaultTestSet does, so it is counted and printed like any other failure.
JamesWrigley
force-pushed
the
fix/50-record-logtestfailure
branch
2 times, most recently
from
September 11, 2026 21:10
d776f0c to
1000d3e
Compare
JamesWrigley
force-pushed
the
fix/50-record-logtestfailure
branch
from
September 11, 2026 21:11
1000d3e to
75046bd
Compare
Member
|
Thanks, and sorry for taking so long to get to this. I took the liberty of cleaning up the code a little and fixing some unrelated failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failing
@test_logsproduces aTest.LogTestFailure, which is not aFail/Error/Broken, soReTestSethad norecordmethod for it and thefailure threw a
MethodErrorinstead of being reported.Convert
LogTestFailuretoFailinrecord, matchingTest.DefaultTestSet, so it is counted and printed like any other failure.Adds a unit test on
record/anyfailed/get_test_counts, and an integrationmodule whose failing
@test_logscausesretestto throwTestSetException(not
MethodError).Fixes #50