-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: mcp support disable ssl validation #9382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new feature to disable SSL certificate validation for MCP (Model Context Protocol) connections, enabling developers to work with self-signed certificates in local development environments. The implementation includes both the backend functionality and UI controls with visual indicators.
Key Changes:
- Added a
disableSslValidationboolean property to the MCP request model that controls therejectUnauthorizedTLS option - Implemented a toggle button in the MCP Certificates modal for users to enable/disable SSL validation
- Added a color-coded indicator (warning/success) on the "Manage Certificates" button to show the current SSL validation status
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/insomnia/src/models/mcp-request.ts |
Adds the disableSslValidation boolean field to the MCP request model with a default value of false |
packages/insomnia/src/main/mcp/common.ts |
Implements the SSL validation bypass by setting rejectUnauthorized: false when the option is enabled |
packages/insomnia/src/ui/components/modals/mcp-certificates-modal.tsx |
Adds UI toggle control and informational messaging for the SSL validation option in the certificates modal |
packages/insomnia/src/ui/components/mcp/mcp-pane.tsx |
Implements visual status indicator on the "Manage Certificates" button showing SSL validation state |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Background
INS-1721
For developers, they may need self-verified certificates for localhost development. MCP inspector runs on a browser, which could support forcing trust in an unsafe cert.
For Insomnia, we could provide an
SSL Certificate Validationoption for developers, which could help them to develop with a self-signed cert.Changes