JOSS Review #138
Description
Hello! I'm creating this issue as part of the review of your submission to JOSS at openjournals/joss-reviews#9066. Please don't close this issue until the points have been addressed.
I have tested the tool on an Ubuntu machine and I was able to run the program as per their instructions.
Few remarks.
- Can you add a citation or a reference to FracMinHash. This would help the reader further explore.
- Quick start has multiple steps - why cannot this be a single step? I do not see a compelling reason to have separate steps. Specially since no processing is done between the steps.
- Please verify that the links in Conda page are correct https://anaconda.org/bioconda/yacht. There seems to be a link to Usher and I do not see the connection.
- Ensure your program supports all operating systems. Since you are publishing at conda, this can be achieved without much trouble.
Minor remark
- Github README could be overwhelming for a novice bioinformatician. Tool performs a simple hypothesis test and that should be the main focus. Having a WIKI in Github for other parameters might improve the user experience drastically.