Skip to content

fix(code): close remaining owner-only credential storage gaps #135

Description

@danny-avila

Follow-up to #107 and #112. Owner-only credential and quarantine storage still has three known gaps:

  • Windows ACLs and macOS extended ACLs are not validated, so mode-only checks can accept data accessible to another account.
  • Only the immediate container is checked; a writable ancestor can replace a private directory.
  • An identity path that is a bind-mount target passes preflight but fails at rename with EBUSY after the one-time pairing code is redeemed.

Please add platform-appropriate ACL validation or fail closed, make path validation resistant to writable-ancestor replacement, and reject or safely support non-replaceable bind-mounted destinations before redeeming a pairing code. Include focused cross-account and preflight regression tests.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions