Skip to content

Commit 46160be

Browse files
Ignore vulnerability GHSA-4xh5-x5gv-qwph (#145)
* Ignore vulnerability GHSA-4xh5-x5gv-qwph Why these changes are being introduced: The vulnerability GHSA-4xh5-x5gv-qwph is triggering an error from pip-audit, but technically running python >= 3.12 is sufficient to mitigate the risk. Until pip releases a new release, even though we have no risk, pip-audit will continue to fail. How this addresses that need: * Explicitly ignores the vulnerability during vulnerability scanning. Side effects of this change: * None Relevant ticket(s): * None
1 parent 9663a95 commit 46160be

File tree

8 files changed

+1323
-1065
lines changed

8 files changed

+1323
-1065
lines changed

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@ repos:
2424
types: ["python"]
2525
- id: pip-audit
2626
name: pip-audit
27-
entry: pipenv run pip-audit
27+
entry: pipenv run pip-audit --ignore-vuln GHSA-4xh5-x5gv-qwph
2828
language: system
2929
pass_filenames: false

Makefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,13 @@ ruff: # Run 'ruff' linter and print a preview of errors
5959
pipenv run ruff check .
6060

6161
safety: # Check for security vulnerabilities and verify Pipfile.lock is up-to-date
62-
pipenv run pip-audit
62+
pipenv run pip-audit --ignore-vuln GHSA-4xh5-x5gv-qwph
6363
pipenv verify
6464

6565
lint-apply: # Apply changes with 'black' and resolve 'fixable errors' with 'ruff'
6666
black-apply ruff-apply
6767

6868
black-apply: # Apply changes with 'black'
69-
pipenv run black .
7069

7170
ruff-apply: # Resolve 'fixable errors' with 'ruff'
7271
pipenv run ruff check --fix .

Pipfile.lock

Lines changed: 1317 additions & 1055 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ ignore = [
4646
"PLR0912",
4747
"PLR0913",
4848
"PLR0915",
49-
"S320",
5049
"S321",
5150
]
5251

tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# ruff: noqa: E501, PT004
21
import json
32
from datetime import timedelta
43
from unittest import mock

tests/test_aws/test_cloudwatch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,6 @@ def test_cloudwatchlogs_client_get_log_events_raise_error(
4545
):
4646
with pytest.raises(
4747
ECSTaskLogStreamDoesNotExistError,
48-
match="No log streams found for task id 'DOES_NOT_EXIST'.",
48+
match=r"No log streams found for task id 'DOES_NOT_EXIST'.",
4949
):
5050
assert cloudwatchlogs_client.get_log_events(task_id="DOES_NOT_EXIST")

tests/test_aws/test_ecs.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def test_client_run_raise_error_if_task_definition_does_not_exist(
8080
)
8181
with pytest.raises(
8282
ECSTaskDefinitionDoesNotExistError,
83-
match="No task definition found for 'DOES_NOT_EXIST'.",
83+
match=r"No task definition found for 'DOES_NOT_EXIST'.",
8484
):
8585
bad_ecs_client.run(run_type="review")
8686

@@ -114,7 +114,7 @@ def test_ecs_client_monitor_task_raise_error(
114114

115115
with pytest.raises(
116116
ECSTaskRuntimeExceededTimeoutError,
117-
match="Task runtime exceeded set timeout of 2 seconds.",
117+
match=r"Task runtime exceeded set timeout of 2 seconds.",
118118
):
119119
ecs_client.monitor_task(task_arn, timeout=2)
120120

@@ -126,7 +126,7 @@ def test_ecs_client_get_task_status_success(ecs_client, mock_ecs_task_state_tran
126126

127127
def test_ecs_client_get_task_status_raise_error(ecs_client):
128128
with pytest.raises(
129-
ECSTaskDoesNotExistError, match="No tasks found for id 'DOES_NOT_EXIST'."
129+
ECSTaskDoesNotExistError, match=r"No tasks found for id 'DOES_NOT_EXIST'."
130130
):
131131
assert ecs_client.get_task_status(task_id="DOES_NOT_EXIST")
132132

webapp/utils/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# ruff: noqa: G004
21
import base64
32
import json
43
import logging

0 commit comments

Comments
 (0)