-
-
Notifications
You must be signed in to change notification settings - Fork 852
feat: add comprehensive Trello connector with full test suite #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
- Add TrelloConnector class with API integration for boards, cards, and comments - Implement Trello indexing task for background document processing - Add TRELLO_CONNECTOR enum to DocumentType and SearchSourceConnectorType - Create /trello/boards/ API endpoint for board fetching - Add TrelloCredentialsRequest Pydantic model for API validation - Implement Trello search functionality in ConnectorService - Add comprehensive test suite with 80+ test cases covering: * Unit tests for TrelloConnector class with error handling * Integration tests for API endpoints and database operations * Frontend component tests for configuration and creation pages * End-to-end workflow testing - Add test configuration with shared fixtures and mock data - Create test runner script and comprehensive documentation - Fix missing TRELLO_CONNECTOR in SearchSourceConnectorType enum - Add frontend TrelloBoard interface and connector page - Implement complete connector creation flow with board selection - Add robust error handling for API failures, timeouts, and malformed data - Include security considerations for credential handling and input validation
|
@Mandar77 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Mandar77 Getting this err: |
|
Hi @Mandar77 , are you still working on this ? |
|
@CREDO23 I don't think so. Would you like to give this a try until I sort out a zoom pro account for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚙️ Scanning changes in 8bbc8db..e20e9fa for bugs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Motivation and Context
FIX #
Changes Overview
Screenshots
API Changes
Types of changes
Testing
Checklist:
Review by RecurseML
🔍 Review performed on 8bbc8db..e20e9fa
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (5)
•
surfsense_backend/tests/connectors/test_trello_connector_comprehensive.py•
surfsense_web/app/dashboard/[search_space_id]/connectors/add/trello-connector/page.tsx•
surfsense_web/__tests__/pages/trello-connector.test.tsx•
surfsense_backend/tests/connectors/test_trello_connector.py•
surfsense_web/__tests__/components/EditTrelloConnectorConfig.test.tsx⏭️ Files skipped (trigger manually) (16)
README.mdTRELLO_CONNECTOR_IMPLEMENTATION_SUMMARY.mdsurfsense_backend/TRELLO_TESTS_README.mdsurfsense_backend/app/connectors/trello_connector.pysurfsense_backend/app/db.pysurfsense_backend/app/routes/search_source_connectors_routes.pysurfsense_backend/app/tasks/connector_indexers/trello_indexer.pysurfsense_backend/pyproject.tomlsurfsense_backend/run_trello_tests.pysurfsense_backend/tests/conftest.pysurfsense_backend/tests/integration/test_trello_integration.pysurfsense_backend/uv.locksurfsense_web/app/dashboard/[search_space_id]/connectors/add/page.tsxsurfsense_web/components/editConnector/EditTrelloConnectorConfig.tsxsurfsense_web/components/editConnector/types.tssurfsense_web/contracts/enums/connector.tsHigh-level PR Summary