-
-
Notifications
You must be signed in to change notification settings - Fork 849
Search Space container not fully clickable on dashboard #453 #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@msinha569 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe dashboard page component is modified to improve space card interactivity by reorganizing padding distribution and styling. Padding is moved from the inner content wrapper to the Link element, and cursor-pointer styling is applied to the Link. The bottom metadata row is also simplified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)**/*.{jsx,tsx}📄 CodeRabbit inference engine (.rules/require_unique_id_props.mdc)
Files:
🪛 GitHub Actions: Code Quality Checkssurfsense_web/app/dashboard/page.tsx[error] 338-344: Biome check-web formatter would modify file. Formatting issues detected around lines 338-344. Run 'pre-commit run biome-check-web --all-files' or format the file to fix. 🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by RecurseML
🔍 Review performed on 49b7cb9..d59478e
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_web/app/dashboard/page.tsx
|
@msinha569 Thanks 👍 |
Title: Fix: make entire Search Space container clickable on dashboard (#453)
This PR resolves Issue #453, where only parts of the Search Space cards on the dashboard were clickable.
The entire card area is now fully interactive, providing a consistent and intuitive user experience.
Description
Previously, users could only click specific elements inside a Search Space container — such as the text or image — to navigate to the associated search space.
Clicks on other areas (like the border or empty space) had no effect, leading to inconsistent interaction behavior.
This PR fixes the issue by:
This ensures the full card acts as a single, unified click target, while preserving accessibility and hover effects.
Motivation and Context
The change improves UX consistency across the SurfSense dashboard.
It aligns with standard UI expectations — users anticipate that clicking anywhere inside a card triggers the same navigation.
Fixes: #453
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR fixes a clickability issue on the dashboard where only specific elements within Search Space cards were interactive. The fix restructures the card layout by moving the
Linkcomponent to wrap more of the card content and adjusting CSS classes to ensure the entire card area is clickable. This provides a more intuitive and consistent user experience when navigating to search spaces.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/app/dashboard/page.tsxSummary by CodeRabbit