feat: fix chat initialization logic in ResearcherPage #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a ref to track if initial connectors have been set for new chats. - Updated the effect to reset the flag when the chat ID changes, ensuring connectors are set only once on initial mount. - Improved the condition for setting default sources for new chats to prevent unnecessary updates.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on a9c9e3f..461d6ab
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_web/app/dashboard/[search_space_id]/researcher/[[...chat_id]]/page.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: fix chat initialization logic in ResearcherPage
Motivation and Context
FIX #
Screenshots
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR fixes a bug in the chat initialization logic for the ResearcherPage where default source connectors were being repeatedly set on every render. The fix introduces a
useRefflag to ensure that the initial connectors are only set once when a new chat is created, preventing unnecessary re-initialization. The flag is properly reset when switching between different chats.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/app/dashboard/[search_space_id]/researcher/[[...chat_id]]/page.tsx