fix: Checking subspace creation when not members of Parent Space - Meeds-io/MIPs#227

Prior to this change, the parent space creation check was made using 'isMember' instead of '!isMember'

Author: boubaker

component/core/src/main/java/io/meeds/social/space/service/SpaceServiceImpl.java

@@ -1414,7 +1414,7 @@ private void checkSubspaceCreationAllowed(Space space, long parentSpaceId, Strin
       return;
     }
     Space parentSpace = getSpaceById(parentSpaceId);
-    if (isMember(parentSpace, username)) {
+    if (!isMember(parentSpace, username)) {
       throw new SpaceException(Code.SPACE_PERMISSION,
                                String.format("User %s isn't allowed to create subspace under parent space with id %s",
                                              username,

component/core/src/test/java/org/exoplatform/social/core/space/spi/SpaceServiceTest.java

@@ -2607,14 +2607,15 @@ public void testCreateSubspace() {
     space2.setPrettyName("spaceChild");
     space2.setRegistration(Space.OPEN);
     space2.setDescription("description of space spaceChild");
-    space2.setTemplateId(2);
+    space2.setTemplateId(2l);
     space2.setVisibility(Space.PRIVATE);
 
-    String parentSpaceId = space.getId();
+    long parentSpaceId = space.getSpaceId();
     Exception exception = assertThrows(SpaceException.class,
-                                       () -> spaceService.createSpace(space2, ROOT_NAME, null, Long.parseLong(parentSpaceId)));
+                                       () -> spaceService.createSpace(space2, ROOT_NAME, null, parentSpaceId));
 
-    assertEquals("User root isn't allowed to create subspace under parent space with id " + parentSpaceId,
+    assertEquals("Subspace template '%s' is not allowed under parent template '%s'".formatted(space2.getTemplateId(),
+                                                                                              2l),
                  exception.getMessage());
   }