Skip to content

Commit 9337c1c

Browse files
committed
ci: fix the announce-release Slack post
1 parent 8d08f47 commit 9337c1c

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

.github/workflows/publish-release.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ jobs:
2525
runs-on: ubuntu-latest
2626
steps:
2727
- uses: actions/checkout@v6
28+
2829
- id: name-hash
2930
name: Get Slack name and hash
3031
shell: bash
@@ -33,6 +34,7 @@ jobs:
3334
NAME_VERSION_TEXT=$(jq --raw-output '.name + "@" + .version' package.json )
3435
NAME_VERSION_TEXT_STRIPPED="${NAME_VERSION_TEXT#@}"
3536
echo "NAME_VERSION=$NAME_VERSION_TEXT_STRIPPED" >> "$GITHUB_OUTPUT"
37+
3638
- id: final-text
3739
name: Get Slack final text
3840
shell: bash
@@ -45,20 +47,20 @@ jobs:
4547
FINAL_TEXT="<!subteam^$SUBTEAM_TEXT> $DEFAULT_TEXT"
4648
fi
4749
echo "FINAL_TEXT=$FINAL_TEXT" >> "$GITHUB_OUTPUT"
50+
4851
- name: Post to a Slack channel
4952
if: inputs.slack-subteam != ''
5053
uses: slackapi/slack-github-action@af78098f536edbc4de71162a307590698245be95
54+
continue-on-error: true
5155
with:
56+
webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
57+
webhook-type: incoming-webhook
5258
payload: |
5359
{
5460
"text": "${{ steps.final-text.outputs.FINAL_TEXT }}",
5561
"icon_url": "${{ inputs.slack-icon-url }}",
5662
"username": "${{ inputs.slack-username }}"
5763
}
58-
env:
59-
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
60-
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
61-
continue-on-error: true
6264
6365
publish-release:
6466
name: Publish release
@@ -75,11 +77,13 @@ jobs:
7577
# need for updating the shorthand major version tag.
7678
fetch-depth: 0
7779
ref: ${{ github.sha }}
80+
7881
- name: Publish release
7982
uses: MetaMask/action-publish-release@v3
8083
id: publish-release
8184
env:
8285
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
86+
8387
- name: Update shorthand major version tag
8488
run: |
8589
./.github/workflows/scripts/update-major-version-tag.sh \

0 commit comments

Comments
 (0)