Skip to content

[JitDiff X64] [EgorBo] Make BitArray.CreateArray(ReadOnlySpan<bool>) memory safe #2114

Description

@MihuBot

Job completed in 22 minutes 6 seconds (remote runner delay: 1 minute 2 seconds).
dotnet/runtime#131838

Main commit: dotnet/runtime@e275aeb
PR commit: EgorBo/runtime-1@b696d26

Diffs

Found 90 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 158318310
Total bytes of diff: 158318324
Total bytes of delta: 14 (0.00 % of base)
Total relative delta: Infinity
    diff is a regression.
    relative diff is a regression.


Total byte diff includes -51 bytes from reconciling methods
	Base had    1 unique methods,       51 unique bytes
	Diff had    0 unique methods,        0 unique bytes

Top file regressions (bytes):
          14 : System.Private.CoreLib.dasm (0.00 % of base)

1 total files with Code Size differences (0 improved, 1 regressed), 353 unchanged.

Top method regressions (bytes):
          51 (Infinity of base) : OpenTelemetry.dasm - OpenTelemetry.Resources.OtelEnvResourceDetector:.cctor() (FullOpts)
          14 (7.61 % of base) : System.Private.CoreLib.dasm - System.Collections.BitArray:CreateArray(System.ReadOnlySpan`1[bool],byref):byte[] (FullOpts)

Top method improvements (bytes):
         -51 (-100.00 % of base) : OpenTelemetry.dasm - 

Top method regressions (percentages):
          51 (Infinity of base) : OpenTelemetry.dasm - OpenTelemetry.Resources.OtelEnvResourceDetector:.cctor() (FullOpts)
          14 (7.61 % of base) : System.Private.CoreLib.dasm - System.Collections.BitArray:CreateArray(System.ReadOnlySpan`1[bool],byref):byte[] (FullOpts)

Top method improvements (percentages):
         -51 (-100.00 % of base) : OpenTelemetry.dasm - 

3 total methods with Code Size differences (1 improved, 2 regressed), 816620 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions