Skip to content

Commit 6020d20

Browse files
committed
update tests
Signed-off-by: Sarah Yurick <[email protected]>
1 parent 27e9502 commit 6020d20

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

tests/stages/video/clipping/test_video_frame_extraction.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ def test_get_frames_from_ffmpeg_gpu_failure_fallback(self, mock_logger: Any, moc
140140

141141
# Verify warning was logged
142142
mock_logger.warning.assert_called_once_with(
143-
"Caught ffmpeg runtime error with `use_gpu=True` option, falling back to CPU."
143+
"Caught FFmpeg runtime error with `use_gpu=True` option, falling back to CPU."
144144
)
145145

146146
# Verify result
@@ -455,7 +455,7 @@ def test_process_pynvc_exception_fallback(
455455

456456
# Verify warning was logged
457457
mock_logger.warning.assert_called_once_with(
458-
"Got exception PyNvCodec error with PyNvVideoCodec decode, trying ffmpeg CPU fallback"
458+
"Got exception PyNvCodec error with PyNvVideoCodec decode, trying FFmpeg CPU fallback"
459459
)
460460

461461
# Verify FFmpeg was called with CPU fallback

tests/stages/video/preview/test_preview.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ def test_generate_preview_subprocess_error(self, mock_subprocess: "MagicMock", m
250250

251251
# Mock subprocess error
252252
mock_subprocess.side_effect = subprocess.CalledProcessError(
253-
returncode=1, cmd=["ffmpeg"], output=b"ffmpeg error output"
253+
returncode=1, cmd=["ffmpeg"], output=b"FFmpeg error output"
254254
)
255255

256256
# Create window with mp4 bytes
@@ -276,26 +276,26 @@ def test_generate_preview_subprocess_error(self, mock_subprocess: "MagicMock", m
276276
# Verify error was logged
277277
mock_logger.error.assert_called_once()
278278
error_msg = mock_logger.error.call_args[0][0]
279-
assert "ffmpeg command failed with return code 1" in error_msg
279+
assert "FFmpeg command failed with return code 1" in error_msg
280280

281281
# Verify warning was logged with command
282282
mock_logger.warning.assert_called()
283283
warning_calls = [call[0][0] for call in mock_logger.warning.call_args_list]
284-
assert any("ffmpeg command:" in msg for msg in warning_calls)
285-
assert any("ffmpeg output:" in msg for msg in warning_calls)
284+
assert any("FFmpeg command:" in msg for msg in warning_calls)
285+
assert any("FFmpeg output:" in msg for msg in warning_calls)
286286

287287
# Verify webp_bytes was not set
288288
assert window.webp_bytes is None
289289

290290
@patch("nemo_curator.stages.video.preview.preview.make_pipeline_temporary_dir")
291291
@patch("subprocess.check_output")
292292
def test_generate_preview_with_ffmpeg_output(self, mock_subprocess: "MagicMock", mock_temp_dir: "MagicMock"):
293-
"""Test preview generation when ffmpeg produces output."""
293+
"""Test preview generation when FFmpeg produces output."""
294294
# Mock temporary directory context manager
295295
mock_temp_dir.return_value.__enter__.return_value = pathlib.Path("temp/preview")
296296

297297
# Mock subprocess with output
298-
mock_subprocess.return_value = b"ffmpeg info message"
298+
mock_subprocess.return_value = b"FFmpeg info message"
299299

300300
# Create window with mp4 bytes
301301
window = _Window(start_frame=0, end_frame=30, mp4_bytes=b"fake_mp4_data")
@@ -318,10 +318,10 @@ def test_generate_preview_with_ffmpeg_output(self, mock_subprocess: "MagicMock",
318318
with patch("nemo_curator.stages.video.preview.preview.logger") as mock_logger:
319319
stage._generate_preview(window)
320320

321-
# Verify warning was logged about ffmpeg output
321+
# Verify warning was logged about FFmpeg output
322322
mock_logger.warning.assert_called_once()
323323
warning_msg = mock_logger.warning.call_args[0][0]
324-
assert "ffmpeg output: ffmpeg info message" in warning_msg
324+
assert "FFmpeg output: FFmpeg info message" in warning_msg
325325

326326
# Verify webp_bytes was set
327327
assert window.webp_bytes == b"fake_webp_data"

0 commit comments

Comments
 (0)