Repository navigation
Conversation
Sync the dialect reference with the dynamic-shape contract and cover the runtime prefix-product and scalar-order lowering paths. Also fix a dangling comment in the neighboring left-inverse test. Test Plan: ```bash build-cutlass-compiler/llvm-project/bin/llvm-lit -v build-cutlass-compiler/cute_ir/test/Conversion/CuteToBase/pipeline_full.mlir build-cutlass-compiler/cute_ir/test/Conversion/CuteExpandOps/LayoutAlgebra/left_inverse.mlir build-cutlass-compiler/cute_ir/test/Conversion/CuteExpandOps/LayoutAlgebra/right_inverse.mlir build-cutlass-compiler/cute_ir/test/Dialect/Cute/LayoutAlgebra/right_inverse.mlir build-cutlass-compiler/cute_ir/test/Dialect/Cute/LayoutAlgebra/right_inverse_errors.mlir ctest --test-dir build-cutlass-compiler -R 'cg_right_inverse_test' --output-on-failure git diff --check ```
|
Hi @ccecka, following up on the fix for #3471. Would you be able to review the dynamic-shape/static-integer-stride |
|
Hi @ccecka, following up on the September 24 review request: is the dynamic-shape/static-stride |
|
This PR has been labeled |
|
This PR is still needed and awaiting review. @ccecka, could you review it or point me to the right compiler reviewer? Happy to address feedback. |
|
I'm not the right reviewer for this. Perhaps @kerrmudgeon knows who should review this? |
Summary
right_inverseto accept dynamic shapes when every stride is a fully static integerFor
(16, N):(1, 16), this returns the functionally equivalent uncoalesced(16, N):(1, 16)layout demonstrated by PyCuTe in the issue discussion. Producing the canonical16*N:1representation depends on dynamic coalescing, which is tracked separately in #3469. Consequently, callers that require a coalesced rank-1 inverse, including theblackwell_helpers.pyTMA-shape path, still depend on #3469.Testing
cmake --build build-cutlass-compiler --target check-cute -j 8(236/236 passed)cmake --build build-cutlass-compiler --target check-cutegen-unittests -j 8(220/220 passed across 25 test binaries)ctest --test-dir build-cutlass-compiler -R 'cg_right_inverse_test' --output-on-failure(1/1 passed)git diff --checkThe compiler and tests were built CPU-only against the LLVM revision pinned by
cutlass_compiler/LLVM_COMMIT.Contribution disclosure
AI assistance was used for repository research, implementation, independent review, and running the checks above.
Fixes #3471