Merge pull request #912 from mattrjacobs/only-check-cache-enabled-once-observable-collapser

Only check the property value of isRequestCacheEnabled() once in HystrixObservableCollapser

Author: mattrjacobs

hystrix-core/src/main/java/com/netflix/hystrix/HystrixObservableCollapser.java

@@ -410,8 +410,10 @@ public Observable<ResponseType> toObservable() {
      */
     public Observable<ResponseType> toObservable(Scheduler observeOn) {
 
+        final boolean isRequestCacheEnabled = getProperties().requestCacheEnabled().get();
+
         /* try from cache first */
-        if (getProperties().requestCacheEnabled().get()) {
+        if (isRequestCacheEnabled) {
             Observable<ResponseType> fromCache = requestCache.get(getCacheKey());
             if (fromCache != null) {
                 metrics.markResponseFromCache();
@@ -422,7 +424,7 @@ public Observable<ResponseType> toObservable(Scheduler observeOn) {
         RequestCollapser<BatchReturnType, ResponseType, RequestArgumentType> requestCollapser = collapserFactory.getRequestCollapser(collapserInstanceWrapper);
         Observable<ResponseType> response = requestCollapser.submitRequest(getRequestArgument());
         metrics.markRequestBatched();
-        if (getProperties().requestCacheEnabled().get()) {
+        if (isRequestCacheEnabled) {
             /*
              * A race can occur here with multiple threads queuing but only one will be cached.
              * This means we can have some duplication of requests in a thread-race but we're okay