AppImage release archives use commit hash instead of the release tag

[j4reporting]

the Linux appImages release archives use the commit hash instead the release tag in the directory name

$ tar tvf vkquake-1.31.1_linux64.tar.gz
drwxr-xr-x root/root         0 2024-08-02 18:45 vkquake-f09814e9_linux64/
-rwxr-xr-x root/root   2778304 2024-08-02 18:45 vkquake-f09814e9_linux64/vkquake.AppImage
-rw-r--r-- root/root     18092 2024-08-02 18:45 vkquake-f09814e9_linux64/LICENSE.txt


$ tar tvf vkquake-1.30.1_linux64.tar.gz
drwxr-xr-x root/root         0 2023-03-15 04:00 vkquake-1.30.1_linux64/
-rwxr-xr-x root/root   2720960 2023-03-15 04:00 vkquake-1.30.1_linux64/vkquake.AppImage
-rw-r--r-- root/root     18092 2023-03-15 04:00 vkquake-1.30.1_linux64/LICENSE.txt

[vsonnier]

Thanks, that should be fixed.

Update : not really ?

[vsonnier]

OK still not good. I'll let more competent people try their turn.

Introduced by e8cf9ed ?

[j4reporting]

I don´t see where build-appimage.sh would run. It looks like this could be part of an extra release build process and should run when a new tag was created.
Here VERSION is set to the version string extracted from quakedef.h or now quakever.h and then it starts the normal

The push/merge linux ci process uses run-in-docker.sh with VERSION set to the commit hash, and that should remain as it is.

The latest release is identical to the CI process for the new tag and renamed to vkquake_1.31.1_linux.tar.gz. This will not change the name of archived directory.

[j4reporting]

It could have been a temporary release branch with a modified docker statement to build the image with build-appimage.sh instead of run-in-docker.sh

[j4reporting]

@vsonnier, I guess this requires a special handling for linux release binaries.

git tag  <releasetag>
git branch tmp_release
git switch tmp_release
sed -i -e 's/vkquake-${VERSION}/vkquake-<releasetag>/' Packaging/AppImage/run-in-docker.sh
git commit Packaging/AppImage/run-in-docker.sh
git push

download artifact linux appimage archive and upload as official release...

e.g. release tag 0.0.1

$ unzip -l /tmp/vkQuake\ archive.zip 
Archive:  /tmp/vkQuake archive.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
  2657517  10-25-2025 14:57   vkquake-0.0.1_linux64.tar.gz
---------                     -------
  2657517                     1 file

$ tar tvf vkquake-0.0.1_linux64.tar.gz 
drwxr-xr-x root/root         0 2025-10-25 16:57 vkquake-0.0.1_linux64/
-rw-r--r-- root/root     18092 2025-10-25 16:57 vkquake-0.0.1_linux64/LICENSE.txt
-rwxr-xr-x root/root   2782400 2025-10-25 16:57 vkquake-0.0.1_linux64/vkquake.AppImage

delete the tmp_release branch

[j4reporting]

or change VERSION=${GITHUB_SHA::8} to VERSION='<releasetag>' in .github/workflows/build-linux.yml in the tmp release branch

[vsonnier]

Hi @j4reporting Happy Christmas and New Year in advance, I'm trying to cleanup things... Is there anything to do, or worth doing, about this issue ?

[j4reporting]

Hi @vsonnier , hope you had a wonderful and peaceful Christmasl

You have to adapt the release process for all or at least for the linux appimage with the steps outlined above.
Basically for the next release e.g. 1.33.1 you create the tag and push the tag to github, then create a new branch and edit file
.github/workflows/build-linux.yml and change VERSION=${GITHUB_SHA::8} to VERSION='1.33.1' in line 24.
Push the branch to trigger the build process. The binaries will be identical to the binaries build for the tag push with one change though. The directory name of the linux appimage will be vkquake-1.33.1_linux64 instead of vkquake-${GITHUB_SHA::8}_linux64 !

Attach those archives as the latest release, or at least use the linux archive instead of the linux artifact created by the 1.33.1 tag build.
Then delete the branch.
There is no other way to create release archives with the release tag in the directory name instead of the guthub shortcommit string.

Bonne année! German has an expression that is used before Jan 1. "'Guten Rutsch!" :)

[Novum]

When running the build-appimage.sh script it will extract the version from quakedef.h via get-version.sh. Something broke this. Or the releases are done in a different way than I did them.

In CI VERSION is set to the git hash on purpose. Those builds shouldn't be used for the release, instead run build-appimage.sh locally