Summary
The SAML SSO auth servlets SLS (Single Logout Service) and ACS (Assertion Consumer Service) have no test coverage — no unit or integration tests exist for either.
src/main/java/servlets/SLS.java — no SLSTest / SLSIT
src/main/java/servlets/ACS.java — no ACSTest / ACSIT
By contrast, the non-SAML auth servlets Login and Logout do have IT coverage (LoginIT, LogoutIT).
Why it matters
These are authentication-path servlets in a security training application — exactly the code that should be tested. The gap surfaced during the Jakarta migration (#861): OpenRewrite tried to bundle a behavioral change (ses.invalidate() → request.logout()) into these files, and for SLS/ACS there was no test that would have caught a regression (whereas LogoutIT would have).
Scope
Note: depends on the SAML Auth API, which is being moved to the Jakarta-compatible java-saml 3.0.0 + java-saml-servlet-jakarta as part of #861 — coordinate so tests target the post-migration API.
Out of scope
MobileLogin coverage — the mobile side is handled under a separate initiative.
Discovered during #861.
Summary
The SAML SSO auth servlets
SLS(Single Logout Service) andACS(Assertion Consumer Service) have no test coverage — no unit or integration tests exist for either.By contrast, the non-SAML auth servlets
LoginandLogoutdo have IT coverage (LoginIT,LogoutIT).Why it matters
These are authentication-path servlets in a security training application — exactly the code that should be tested. The gap surfaced during the Jakarta migration (#861): OpenRewrite tried to bundle a behavioral change (
ses.invalidate()→request.logout()) into these files, and forSLS/ACSthere was no test that would have caught a regression (whereasLogoutITwould have).Scope
ACS(consumes the SAML assertion / IdP response, establishes the session).SLS(handles SAML single-logout).Note: depends on the SAML
AuthAPI, which is being moved to the Jakarta-compatiblejava-saml3.0.0 +java-saml-servlet-jakartaas part of #861 — coordinate so tests target the post-migration API.Out of scope
MobileLogincoverage — the mobile side is handled under a separate initiative.Discovered during #861.