Web portal offers prolongate button when PWO orderstate is already OrderProlongate, leading to customizer error

[RobertMueller2]

Is this a regression?

No

Severity

🟡 Minor – small but noticeable issue

Please provide the branch(es) you discovered this issue in

v93

Environment Details

OneIM 9.3.1, portal up to 5d25687, any browser

Please provide a minimal set of steps to reproduce the issue

1. with a portal user, create a PWO with limited ValidUntil and where the product has a non-selfservice workflow. Have approvers approve until the PWO is assigned.
2. with the same portal user, order prolongate. Do not run through the approval workflow.
3. open request history again, open the sidesheet on the same PWO.
4. Find that the prolongate button is enabled and clicking it causes a customizer error

Description

When trying to use prolongate on a PWO that is already in state OrderProlongate, a customizer error appears in the web portal.

Describe what you expected to happen versus what actually happened

My expectation is that the prolongate button is disabled if the customizer does not allow to prolongate.
Instead, it is enabled and a customizer error appears.

Relevant logs or console output

Add a screenshot(s) if that helps illustrate the problem

Suggested Fix

imxweb\projects\qer\src\lib\request-history\itshop-request.ts:

    // If the user can unsubscribe, we consider that the user can also renew
    this.canProlongate = this.UnsubscribeRequestAllowed.value;

This is a simplification, we should actually replicate the customizer behaviour.

Anything else?

Additionally, the request history grid can be confusing to end users without knowledge of the inner workings of OneIM when it comes to prolongate. For the state OrderProlongate, the grid displays "Renewed until". But the renewal has not been approved yet, it should really say "Renewing" in that instance. This is one reason why people may want to try the prolongate button again for a longer prolongation, because the UI suggests the first attempt has already been approved.

Moreover, customizer errors in general are not end user friendly, there are still several places where they show.

Before submitting...

• I have searched for existing issues that match this one on github and on the community support page
• I have included all necessary details to reproduce this issue