fix(link): correct link cache mode bitwise comparison (#1635)

xrgzs · web-flow · commit 0866b9075fdf · 2025-11-13T13:52:33.000+08:00
* fix(link): correct link cache mode bitwise comparison

Signed-off-by: MadDogOwner &lt;xiaoran@xrgzs.top&gt;

* refactor(link): use explicit flag equality for link cache mode bitmask checks

Signed-off-by: MadDogOwner &lt;xiaoran@xrgzs.top&gt;

---------

Signed-off-by: MadDogOwner &lt;xiaoran@xrgzs.top&gt;
diff --git a/internal/op/fs.go b/internal/op/fs.go
@@ -173,10 +173,10 @@ func Link(ctx context.Context, storage driver.Driver, path string, args model.Li
 		mode = storage.(driver.LinkCacheModeResolver).ResolveLinkCacheMode(path)
 	}
 	typeKey := args.Type
-	if mode&driver.LinkCacheIP == 1 {
+	if mode&driver.LinkCacheIP == driver.LinkCacheIP {
 		typeKey += "/" + args.IP
 	}
-	if mode&driver.LinkCacheUA == 1 {
+	if mode&driver.LinkCacheUA == driver.LinkCacheUA {
 		typeKey += "/" + args.Header.Get("User-Agent")
 	}
 	key := Key(storage, path)

Original file line number	Diff line number	Diff line change
`@@ -173,10 +173,10 @@ func Link(ctx context.Context, storage driver.Driver, path string, args model.Li`
`173`	`173`	`mode = storage.(driver.LinkCacheModeResolver).ResolveLinkCacheMode(path)`
`174`	`174`	`}`
`175`	`175`	`typeKey := args.Type`
`176`		`- if mode&driver.LinkCacheIP == 1 {`
	`176`	`+ if mode&driver.LinkCacheIP == driver.LinkCacheIP {`
`177`	`177`	`typeKey += "/" + args.IP`
`178`	`178`	`}`
`179`		`- if mode&driver.LinkCacheUA == 1 {`
	`179`	`+ if mode&driver.LinkCacheUA == driver.LinkCacheUA {`
`180`	`180`	`typeKey += "/" + args.Header.Get("User-Agent")`
`181`	`181`	`}`
`182`	`182`	`key := Key(storage, path)`