ADD: debug unit tests (#26)

* add debug unitTests
* Fix assert detected by UnitTests in Debug mode

---------

Co-authored-by: Tomasz Szumski <[email protected]>

Author: zLukas

.github/workflows/base_build.yaml

@@ -70,7 +70,7 @@ jobs:
           tests/scripts/parrallelUT.sh
           tests/scripts/
 
-  linux-unit-tests:
+  linux-unit-tests-release:
     needs: linux-build
     runs-on: ['self-hosted', 'linux', 'x64', 'valgrind']
     timeout-minutes: 120
@@ -98,8 +98,36 @@ jobs:
         sudo chmod +x ${{ github.workspace }}/Bin/Release/*
         ${{ github.workspace }}/tests/scripts/parrallelUT.sh ./SvtJpegxsUnitTests ${{ env.JOBS_NUM }}
 
+  linux-unit-tests-debug:
+    needs: linux-build
+    runs-on: ['self-hosted', 'linux', 'x64', 'valgrind']
+    timeout-minutes: 120
+    steps:
+    - name: 'Harden Runner'
+      uses: step-security/harden-runner@17d0e2bd7d51742c71671bd19fa12bdc9d40a3d6 # v2.8.1
+      with:
+        egress-policy: audit
+
+    - name: 'Setup:  Install dependencies'
+      run: |
+           sudo apt-get update
+           sudo apt-get -y install nasm
+    - name: download build artifacts
+      uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093
+      with:
+        name: "${{ env.LINUX_ARTIFACTS }}"
+
+    - name: 'Unit tests: Debug'
+      run: |
+        echo "Number of processors: ${NPROC}"
+        cd Bin/Debug/
+        ls -l
+        sudo chmod +x ${{ github.workspace }}/tests/scripts/parrallelUT.sh
+        sudo chmod +x ${{ github.workspace }}/Bin/Debug/*
+        ${{ github.workspace }}/tests/scripts/parrallelUT.sh ./SvtJpegxsUnitTests ${{ env.JOBS_NUM }}
+
   linux-unit-tests-valgrind:
-    needs: linux-unit-tests
+    needs: linux-build
     runs-on:  ['self-hosted', 'linux', 'x64', 'valgrind']
     timeout-minutes: 120
     steps:
@@ -134,7 +162,7 @@ jobs:
         ${{ github.workspace }}/tests/scripts/parrallelUT.sh ./SvtJpegxsUnitTests ${{ env.JOBS_NUM }} valgrind
 
   linux-conformance-tests:
-    needs: linux-unit-tests-valgrind
+    needs: linux-build
     runs-on:  ['self-hosted', 'linux', 'x64', 'valgrind']
     timeout-minutes: 120
     steps:
@@ -162,7 +190,7 @@ jobs:
         ./ParallelAllTests.sh ${{ env.JOBS_NUM }}  ${INPUT_FILES_PATH} ${DEC_BIN_DIR}/SvtJpegxsDecApp
       env:
         DEC_BIN_DIR: ${{ github.workspace }}/Bin/Release
-        INPUT_FILES_PATH: /opt/samples/Samples/ConformanceTestDecoder/
+        INPUT_FILES_PATH: /opt/samples
 
   windows-build:
     needs: changes

Source/Lib/Decoder/Codec/Packing.c

@@ -713,7 +713,7 @@ SvtJxsErrorType_t unpack_precinct(bitstream_reader_t* bitstream, precinct_t* pre
         subpkt_len_bytes = bitstream_reader_get_used_bytes(bitstream) - len_before_subpkt_bytes;
         if (subpkt_len_bytes != (pkt_header.gcli_len)) {
             int32_t leftover = (int32_t)pkt_header.gcli_len - subpkt_len_bytes;
-            if (leftover > 0) {
+            if (leftover > 0 && bitstream_reader_is_enough_bytes(bitstream, leftover)) {
                 if (verbose >= VERBOSE_WARNINGS) {
                     fprintf(stderr, "WARNING: (GCLI) skipped=%d\n", leftover);
                 }
@@ -768,7 +768,7 @@ SvtJxsErrorType_t unpack_precinct(bitstream_reader_t* bitstream, precinct_t* pre
         subpkt_len_bytes = bitstream_reader_get_used_bytes(bitstream) - len_before_subpkt_bytes;
         if (subpkt_len_bytes != (pkt_header.data_len)) {
             int32_t leftover = (int32_t)pkt_header.data_len - subpkt_len_bytes;
-            if (leftover > 0) {
+            if (leftover > 0 && bitstream_reader_is_enough_bytes(bitstream, leftover)) {
                 if (verbose >= VERBOSE_WARNINGS) {
                     fprintf(stderr, "WARNING: (DATA) skipped=%d\n", leftover);
                 }
@@ -816,7 +816,7 @@ SvtJxsErrorType_t unpack_precinct(bitstream_reader_t* bitstream, precinct_t* pre
             subpkt_len_bytes = bitstream_reader_get_used_bytes(bitstream) - len_before_subpkt_bytes;
             if (subpkt_len_bytes != ((uint32_t)pkt_header.sign_len)) {
                 int32_t leftover = (int32_t)pkt_header.sign_len - subpkt_len_bytes;
-                if (leftover > 0) {
+                if (leftover > 0 && bitstream_reader_is_enough_bytes(bitstream, leftover)) {
                     if (verbose >= VERBOSE_WARNINGS) {
                         fprintf(stderr, "WARNING: (SIGN) skipped=%d\n", leftover);
                     }