Skip to content

[#1137] [#1138] [#1139] Update of control-item based components #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pylapp merged 11 commits into from
Dec 3, 2025
Merged

[#1137] [#1138] [#1139] Update of control-item based components #138

pylapp merged 11 commits into from
Dec 3, 2025

Conversation

@pylapp
Copy link
Member

@pylapp pylapp commented Nov 18, 2025 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Orange-OpenSource/ouds-ios#1137
Orange-OpenSource/ouds-ios#1138
Orange-OpenSource/ouds-ios#1139

Description

  • Update configurations panes to use read only variants on switch, checkbox and radio
  • Update configurations panes to use new parameter names
  • Update snapshots

Motivation & Context

Types of change

  • Refactoring (non-breaking change)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I checked I am using the last version of OUDS iOS library
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibility review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@pylapp pylapp requested a review from ludovic35 as a code owner November 18, 2025 12:07
@pylapp pylapp mentioned this pull request Nov 18, 2025
Merged
16 tasks
@pylapp
Copy link
Member Author

pylapp commented Nov 18, 2025

@ludovic35 Message de commit

refactor: checkbox, radio and switch components (Orange-OpenSource/ouds-ios#1137) (Orange-OpenSource/ouds-ios#1138) (Orange-OpenSource/ouds-ios#1138) (#138)

Note

Merger d'abord la PR du SDK Orange-OpenSource/ouds-ios#1168

@pylapp pylapp marked this pull request as draft November 18, 2025 12:11
@pylapp pylapp marked this pull request as ready for review November 18, 2025 12:44
@pylapp pylapp force-pushed the refactor/update-control-items branch 2 times, most recently from 6d57f5b to c2f656c Compare November 19, 2025 09:22
@pylapp pylapp force-pushed the refactor/update-control-items branch from c2f656c to 13d5a88 Compare November 26, 2025 10:06
@pylapp pylapp marked this pull request as draft November 27, 2025 16:07
@pylapp pylapp force-pushed the refactor/update-control-items branch 2 times, most recently from d5b5d50 to 37da7f3 Compare November 28, 2025 10:45
pylapp and others added 10 commits November 28, 2025 16:41
@pylapp @ludovic35
feat: add read only variant for checkbox and `checkbox indetermin…
a8e3f7c 
…ate` components (Orange-OpenSource/ouds-ios#1137)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
feat: add read only variant for switch only component (Orange-Ope…
99c3a5c 
…nSource/ouds-ios#1138)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
feat: add read only variant for radio only component (Orange-Open…
e40dceb 
…Source/ouds-ios#1139)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
refactor: additional label now extra label for control item (Orange-O…
8406414 
…penSource/ouds-ios#1139)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
refactor: light design toolbox for tvOS and watchOS
931412d 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
test: update snapshots
48140d1 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
build: point to suitable OUDS iOS version
299ba95 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
test: update snapshots
6210c37 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @ludovic35
build: use last develop version of OUDS iOS Swift package and updat…
179299c 
…e snapshots

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@ludovic35
chore: update changelog and resynchro to last lib version
ca3a3ad
@ludovic35 ludovic35 force-pushed the refactor/update-control-items branch from 37da7f3 to ca3a3ad Compare November 28, 2025 16:18
@ludovic35 ludovic35 marked this pull request as ready for review November 28, 2025 17:38
@ludovic35 ludovic35 changed the title Update of control items [#1137] [#1138] [#1139] Update of control-item based components Dec 2, 2025
@pylapp
chore: clean up
683a156 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp merged commit f47d03f into develop Dec 3, 2025
10 of 13 checks passed
@pylapp pylapp deleted the refactor/update-control-items branch December 3, 2025 10:17
pylapp added a commit that referenced this pull request Dec 3, 2025
@pylapp
refactor: checkbox, radio and switch components (Orange-OpenSource/ou…
9de29cf 
…ds-ios#1137) (Orange-OpenSource/ouds-ios#1138) (Orange-OpenSource/ouds-ios#1138) (#138)

Related to Orange-OpenSource/ouds-ios#1137, Orange-OpenSource/ouds-ios#1138, Orange-OpenSource/ouds-ios#1139

Reviewed-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludovic35 ludovic35 Awaiting requested review from ludovic35 ludovic35 is a code owner

Assignees

@ludovic35 ludovic35

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pylapp @ludovic35