Skip to content

Commit 989b982

Browse files
committed
review
1 parent b059824 commit 989b982

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

flow/activities/flowable.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -520,9 +520,10 @@ func (a *FlowableActivity) GetQRepPartitions(ctx context.Context,
520520
timeoutCtx, cancel := context.WithTimeout(ctx, 10*time.Second)
521521
defer cancel()
522522
if bytes, connErr := tableSizeEstimatorConn.GetTableSizeEstimatedBytes(timeoutCtx, config.WatermarkTable); connErr == nil {
523-
if bytes > 1<<40 { // 1 TiB
524-
msg := fmt.Sprintf("large table detected: %s (%s). Partitioning query may take several hours to execute. "+
525-
"This is normal for tables over 1 TiB.", config.WatermarkTable, utils.FormatTableSize(bytes))
523+
if bytes > 100<<30 { // 100 GiB
524+
msg := fmt.Sprintf("large table detected: %s (%s). Counting/partitioning queries for parallel "+
525+
"snapshotting may take minutes to hours to execute. This is normal for tables over 100 GiB.",
526+
config.WatermarkTable, utils.FormatTableSize(bytes))
526527
a.Alerter.LogFlowInfo(ctx, config.FlowJobName, msg)
527528
}
528529
} else {

flow/connectors/postgres/qrep.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,6 @@ type QRepSyncSink interface {
4141
CopyInto(context.Context, *PostgresConnector, pgx.Tx, pgx.Identifier) (int64, error)
4242
}
4343

44-
func (c *PostgresConnector) SupportsTablePartitioning() bool {
45-
return true
46-
}
47-
4844
func (c *PostgresConnector) GetQRepPartitions(
4945
ctx context.Context,
5046
config *protos.QRepConfig,

0 commit comments

Comments
 (0)