-
Notifications
You must be signed in to change notification settings - Fork 5.5k
13332 components neetokb #19223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13332 components neetokb #19223
Conversation
…es and pagination; add new source for detecting published articles; update package version to 0.1.0 and include dependencies.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Warning Rate limit exceeded@luancazarine has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 49 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (16)
WalkthroughThe changes introduce a new Neetokb component for Pipedream. A shared app module replaces deprecated authentication with private API utilities for requests, article listing, and pagination support. A new polling source fetches published articles at configurable intervals, filters for new items using persistent state, and emits events for each new article discovered. Changes
Sequence Diagram(s)sequenceDiagram
participant Timer as Polling Timer
participant Source as new-published-article
participant App as neetokb App
participant API as Neetokb API
participant DB as Persistent Store
Timer->>Source: trigger emitEvent()
Source->>DB: _getPublishedIds()
DB-->>Source: stored IDs
Source->>App: paginate({fn: listArticles})
loop For each page
App->>API: _makeRequest(path: articles)
API-->>App: articles + pagination data
App-->>Source: yield article items
end
Source->>Source: filter articles not in stored IDs
Source->>Source: emit event for each new article
Source->>DB: _setPublishedIds(updated set)
DB-->>Source: ack
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
components/neetokb/common/constants.mjs(1 hunks)components/neetokb/neetokb.app.mjs(1 hunks)components/neetokb/package.json(2 hunks)components/neetokb/sources/new-published-article/new-published-article.mjs(1 hunks)components/neetokb/sources/new-published-article/test-event.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/neetokb/package.json
📚 Learning: 2025-09-15T22:01:11.472Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 18362
File: components/leonardo_ai/actions/generate-image/generate-image.mjs:103-105
Timestamp: 2025-09-15T22:01:11.472Z
Learning: In Pipedream components, pipedream/platform's axios implementation automatically excludes undefined values from HTTP requests, so there's no need to manually check for truthiness before including properties in request payloads.
Applied to files:
components/neetokb/neetokb.app.mjs
📚 Learning: 2024-10-10T19:18:27.998Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Applied to files:
components/neetokb/sources/new-published-article/new-published-article.mjs
🧬 Code graph analysis (1)
components/neetokb/neetokb.app.mjs (1)
components/neetokb/common/constants.mjs (2)
LIMIT(1-1)LIMIT(1-1)
🔇 Additional comments (4)
components/neetokb/package.json (1)
3-17: LGTM!Version bump to 0.1.0 appropriately reflects the new functionality, and the
@pipedream/platformdependency is correctly added to support the axios and timer utilities used in the new source.components/neetokb/sources/new-published-article/test-event.mjs (1)
1-12: LGTM!The sample event structure is appropriate for testing the new published article source.
components/neetokb/common/constants.mjs (1)
1-1: LGTM!Clean extraction of the pagination limit constant.
components/neetokb/neetokb.app.mjs (1)
1-65: LGTM!The API utility layer and pagination implementation are well-structured. The async generator correctly handles page iteration and early termination via
maxResults.
components/neetokb/sources/new-published-article/new-published-article.mjs
Outdated
Show resolved
Hide resolved
components/neetokb/sources/new-published-article/new-published-article.mjs
Show resolved
Hide resolved
components/neetokb/sources/new-published-article/new-published-article.mjs
Show resolved
Hide resolved
lcaresia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
For Integration QA: |
|
Hi everyone, all test cases are passed! Ready for release! Test reports
|
Resolves #13332
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.