devices: invalidate device cache on device-removed event #397
Conversation
Avoid returning old device when it got removed already. This also
(hopefully) fixes event handlers getting VirtualDevice instead of real
one:
Failed to handle event: sys-usb, device-added:usb, {'device': sys-usb+4-1:0bda:8179:00E04C0001:uffffff}
Traceback (most recent call last):
File "/usr/lib/python3.13/site-packages/qubesadmin/events/__init__.py", line 278, in handle
kwargs['device'] = plugged
^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.13/site-packages/qui/devices/device_widget.py", line 262, in device_added
dev = backend.Device(device, self)
File "/usr/lib/python3.13/site-packages/qui/devices/backend.py", line 156, in __init__
for interface in dev.interfaces:
^^^^^^^^^^^^^^
AttributeError: 'VirtualDevice' object has no attribute 'interfaces'
marmarek
force-pushed
the
dev-cache-fix
branch
from
6713965 to
c95a89c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
==========================================
- Coverage 76.14% 76.10% -0.04%
==========================================
Files 53 53
Lines 9281 9287 +6
==========================================
+ Hits 7067 7068 +1
- Misses 2214 2219 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025112902-4.3&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025111104-4.3&flavor=update
Failed tests58 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/158999#dependencies 20 fixed
Unstable testsPerformance TestsPerformance degradation:14 performance degradations
Remaining performance tests:58 tests
|
2 participants
Avoid returning old device when it got removed already. This also
(hopefully) fixes event handlers getting VirtualDevice instead of real
one: