CI: Use prebuild image when running aiter tests.

[gyohuangxin]

No description provided.

[Copilot]

Pull request overview

This PR refactors the CI workflow to use prebuilt Docker images when running aiter tests, improving build efficiency by building the Docker image once and reusing it across test jobs.

Key changes:

• Introduces a new build_aiter_image job that builds and pushes a Docker image with aiter pre-installed
• Updates test jobs to use the prebuilt image instead of building aiter during test execution
• Removes redundant Docker login step from vllm_benchmark workflow

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
.github/workflows/aiter-test.yaml	Adds image build job, updates environment variables, modifies standard and multi-gpu jobs to use prebuilt image
.github/workflows/vllm_benchmark.yaml	Removes redundant Docker login step since image pulling doesn't require authentication

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The package name should be pyzmq, not zmq. The correct package name for ZeroMQ Python bindings is pyzmq.

Suggested change

	RUN pip install --upgrade pandas zmq einops numpy==1.26.2
	RUN pip install --upgrade pandas pyzmq einops numpy==1.26.2

[Copilot]

Security concern: Docker credentials are being exposed in workflow logs. Consider using docker login --password-stdin to avoid passing credentials via command-line arguments, which can be exposed in process listings and logs. Example:

echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u rocmshared --password-stdin

Suggested change

	docker login -u rocmshared -p ${{ secrets.DOCKER_PASSWORD }}
	echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u rocmshared --password-stdin

[Copilot]

Security concern: Docker credentials are being exposed in workflow logs. Consider using docker login --password-stdin to avoid passing credentials via command-line arguments. Example:

echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u rocmshared --password-stdin

Suggested change

	docker login -u rocmshared -p ${{ secrets.DOCKER_PASSWORD }}
	echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u rocmshared --password-stdin

[Copilot]

Security concern: Docker credentials are being exposed in workflow logs. Consider using docker login --password-stdin to avoid passing credentials via command-line arguments. Example:

echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u rocmshared --password-stdin

Suggested change

	docker login -u rocmshared -p ${{ secrets.DOCKER_PASSWORD }}
	echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u rocmshared --password-stdin

[Copilot]

Inconsistent naming: The image tag uses pre-build- prefix here, but in vllm_benchmark.yaml the image is expected with just the commit SHA (no pre-build- prefix). This will cause the image pull in vllm_benchmark.yaml to fail.

The vllm_benchmark.yaml expects: rocm/aiter-ci:${{ env.GITHUB_COMMIT_SHA }}
But this creates: rocm/aiter-ci:pre-build-${{ env.GITHUB_COMMIT_SHA }}

Either remove the pre-build- prefix here or update vllm_benchmark.yaml to include it.

Suggested change

	IMAGE_TAG=rocm/aiter-ci:pre-build-${{ env.GITHUB_COMMIT_SHA }}
	docker build --network=host --no-cache -t $IMAGE_TAG -f Dockerfile.mod .
	- name: Push Docker image
	run: |
	IMAGE_TAG=rocm/aiter-ci:pre-build-${{ env.GITHUB_COMMIT_SHA }}
	docker login -u rocmshared -p ${{ secrets.DOCKER_PASSWORD }}
	docker push $IMAGE_TAG
	- name: Success message
	run: |
	echo "Successfully prepared image: rocm/aiter-ci:pre-build-${{ env.GITHUB_COMMIT_SHA }}"
	IMAGE_TAG=rocm/aiter-ci:${{ env.GITHUB_COMMIT_SHA }}
	docker build --network=host --no-cache -t $IMAGE_TAG -f Dockerfile.mod .
	- name: Push Docker image
	run: |
	IMAGE_TAG=rocm/aiter-ci:${{ env.GITHUB_COMMIT_SHA }}
	docker login -u rocmshared -p ${{ secrets.DOCKER_PASSWORD }}
	docker push $IMAGE_TAG
	- name: Success message
	run: |
	echo "Successfully prepared image: rocm/aiter-ci:${{ env.GITHUB_COMMIT_SHA }}"