Skip to content

Conversation

@Kurngsy
Copy link

@Kurngsy Kurngsy commented Nov 21, 2025

[

为什么提交这份PR (why to submit this PR)
作为一个rtthread的初学者,对该函数的实现产生了疑惑,尤其是if (stat == RT_THREAD_SUSPEND)部分, 当一线程用该函数试图挂起其他线程时(注释中已说明禁止)该函数将返回OK, 因为很多情况下一线程运行时 其他线程都是被延时挂起让出的。 在阅读了函数注释后我猜测项目组原本的意图可能为以下之一:
。该函数本身具有较高权限 能挂起其他线程,所以注释警告不应如此做
。该函数在本身只能挂起自身 不能挂起其他线程,所以注释说明并报错
。该函数只考虑了挂起自身的情况 挂起其他线程可能会未知错误,所以注释警告
但是现在的函数实现不属于以上情况, 不应仅返回OK , 且不应存在挂起后挂起(在旧版本为断言),说明函数设置了余量来应对用户行为,以下是对余量的进一步补充

你的解决方案是什么 (what is your solution)
。区分挂起与延迟挂起,挂起应重置计时器,并在覆盖时报告。
。将挂起状态按照rtdef细分NTERRUPTIBLE, KILLABLE, UNINTERRUPTIBLE,并可使挂起状态升级。

请提供验证的bsp和config (provide the config and bsp)
BSP: rt-thread-master\bsp\nxp\imx\imxrt\imxrt1064-nxp-evk
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):

[ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
[x] 本拉取/合并请求是一个成熟版本 This PR is mature, 和 ready to be integrated into the repo
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

[x] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
[x] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
[x] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
[x] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
[x] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
[x] 代码是高质量的 Code in this PR is of high quality

Refactor thread suspension logic to improve clarity and correctness.
@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:master
  • 设置PR number为 \ Set the PR number to:10970
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 master 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the master branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added the Kernel PR has src relate code label Nov 21, 2025
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

📌 Code Review Assignment

🏷️ Tag: kernel

Reviewers: GorrayLi ReviewSun hamburger-os lianux-mm wdfk-prog xu18838022837

Changed Files (Click to expand)
  • src/thread.c

📊 Current Review Status (Last Updated: 2025-11-28 17:54 CST)

  • GorrayLi Pending Review
  • ReviewSun Pending Review
  • hamburger-os Pending Review
  • lianux-mm Pending Review
  • wdfk-prog Pending Review
  • xu18838022837 Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Kurngsy
Copy link
Author

Kurngsy commented Nov 26, 2025

@Rbb666 麻烦review一下呢🌹

/* Already suspended, just set the status to success. */
if (stat & RT_THREAD_SUSPEND_MASK)
{
if (RT_SCHED_CTX(thread).sched_flag_ttmr_set == 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的修改我理解是为了判断:某一线程去主动挂起已经休眠中的线程,并停止该线程的定时器?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是,改为默认使新挂起不被唤醒,原逻辑中,新挂起会被delay的旧挂起唤醒

Removed unnecessary blank line in thread.c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kernel PR has src relate code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants