Improved meta title suffix (#4)

Author: eelcoj

README.md

@@ -26,10 +26,6 @@ This creates an initializer:
 ```ruby
 Perron.configure do |config|
   config.site_name = "AppRefresher"
-
-  # Override the defaults (meta) title suffix
-  # Default: `— Perron.configuration.site_name`
-  # config.title_suffix = nil
 end
 ```
 

lib/generators/perron/templates/initializer.rb.tt

@@ -11,12 +11,12 @@ Perron.configure do |config|
 
   # config.default_url_options = {host: "apprefresher.com", protocol: "https", trailing_slash: true}
 
-  # Override the defaults (meta) title suffix
-  # Default: `— Perron.configuration.site_name`
-  # config.title_suffix = nil
-
   # Set default meta values
   # Examples:
   # - `config.metadata.description = "AI-powered tool to keep your knowledge base articles images/screenshots and content up-to-date"`
   # - `config.metadata.author = "Rails Designer"`
+
+  # Set meta title suffix
+  # config.metadata.title_suffix = nil
+  # config.metadata.title_separator = " — "
 end

lib/perron/configuration.rb

@@ -23,7 +23,6 @@ def initialize
       @config.include_root = false
 
       @config.site_name = nil
-      @config.title_suffix = nil
 
       @config.allowed_extensions = [".erb", ".md"]
       @config.exclude_from_public = %w[assets storage]
@@ -36,6 +35,7 @@ def initialize
       }
 
       @config.metadata = ActiveSupport::OrderedOptions.new
+      @config.metadata.title_separator = " — "
     end
 
     def input = "app/content"

lib/perron/metatags.rb

@@ -29,7 +29,7 @@ def tags
         frontmatter = @resource&.metadata&.stringify_keys || {}
         defaults = @config.metadata
 
-        title = frontmatter["title"] || defaults["title"] || @config.site_name
+        title = frontmatter["title"] || defaults["title"] || @config.site_name || Rails.application.name.underscore.camelize
         description = frontmatter["description"] || defaults["description"]
         author = frontmatter["author"] || defaults["author"]
         image = frontmatter["image"] || defaults["image"]
@@ -59,9 +59,12 @@ def tags
     end
 
     def title_tag(content)
-      tag.title(
-        content.then { (it == @config.site_name) ? it : "#{it} #{@config.title_suffix || "— #{@config.site_name}"}" }
-      )
+      resource_title = content.to_s.strip
+      title_suffix = Perron.configuration.metadata.title_suffix&.strip
+
+      suffix = (title_suffix if title_suffix.present? && resource_title != title_suffix)
+
+      tag.title([resource_title, suffix].compact.join(Perron.configuration.metadata.title_separator))
     end
 
     def meta_tag(attributes)

test/dummy/config/application.rb

@@ -10,7 +10,7 @@
 
 require "perron"
 
-module Dummy
+module AppRefresher
   class Application < Rails::Application
     config.load_defaults Rails::VERSION::STRING.to_f
 

test/metatags_test.rb

@@ -7,7 +7,7 @@
 class MetatagsTest < ActiveSupport::TestCase
   setup do
     Perron.configure do |config|
-      config.site_name = "AppRefresher"
+      config.metadata.title_suffix = "AppRefresher"
     end
   end
 
@@ -18,7 +18,19 @@ class MetatagsTest < ActiveSupport::TestCase
     assert_match "<title>Sample Post — AppRefresher</title>", metatags
   end
 
-  test "renders title using site_name when resource has no title" do
+  test "renders only the page title when the page title is the same as the suffix" do
+    Perron.configuration.metadata.title_suffix = nil
+
+    resource = Perron::Resource.new("test/dummy/app/content/pages/about.md")
+    html = Perron::Metatags.new(resource).render
+
+    assert_match "<title>About</title>", html
+    assert_no_match "—", html
+  end
+
+  test "renders title using Rails application name when resource has no title" do
+    Perron.configuration.metadata.title_suffix = nil
+
     resource = Perron::Resource.new("test/dummy/app/content/pages/root.md")
     html = Perron::Metatags.new(resource).render