fix view properties in binding editor

fix CollectionBinding (template reusing)

Author: TimGameDev

UnityWeld/Binding/CollectionBinding.cs

@@ -228,6 +228,7 @@ private void PutTemplateToPool(Template template)
                 _pool.Add(template.ViewModelTypeName, pool = new Queue<Template>());
             }
 
+            template.gameObject.SetActive(false);
             pool.Enqueue(template);
         }
 

UnityWeld/Binding/Internal/PropertyFinder.cs

@@ -15,7 +15,8 @@ public static class PropertyFinder
         /// <summary>
         /// List of types to exclude from the types of components in the UI we can bind to.
         /// </summary>
-        private static readonly HashSet<Type> hiddenTypes = new HashSet<Type>{
+        private static readonly HashSet<Type> hiddenTypes = new HashSet<Type>
+        {
             typeof(AbstractMemberBinding),
             typeof(OneWayPropertyBinding),
             typeof(TwoWayPropertyBinding)
@@ -24,24 +25,31 @@ public static class PropertyFinder
         /// <summary>
         /// Use reflection to find all components with properties we can bind to.
         /// </summary>
-        public static IEnumerable<BindableMember<PropertyInfo>> GetBindableProperties(GameObject gameObject) //todo: Maybe move this to the TypeResolver.
+        public static BindableMember<PropertyInfo>[] GetBindableProperties(GameObject gameObject) //todo: Maybe move this to the TypeResolver.
         {
+            BindableMember<PropertyInfo>[] bindableProperties;
             using(var cache = gameObject.GetComponentsWithCache<Component>())
             {
-                return cache.Components
-                       .SelectMany(component =>
-                       {
-                           var type = component.GetType();
-                           return type
-                                  .GetProperties(BindingFlags.Instance | BindingFlags.Public)
-                                  .Select(p => new BindableMember<PropertyInfo>(p, type));
-                       })
-                       .Where(prop => prop.Member.GetSetMethod(false) != null
-                                      && prop.Member.GetGetMethod(false) != null
-                                      && !hiddenTypes.Contains(prop.ViewModelType)
-                                      && !prop.Member.GetCustomAttributes(typeof(ObsoleteAttribute), true).Any()
-                       );
+                bindableProperties = cache.Components
+                                          .SelectMany(component =>
+                                          {
+                                              var type = component.GetType();
+                                              return type
+                                                     .GetProperties(BindingFlags.Instance | BindingFlags.Public)
+                                                     .Select(p => new BindableMember<PropertyInfo>(p, type));
+                                          })
+                                          .Where(prop => prop.Member.GetSetMethod(false) != null
+                                                         && prop.Member.GetGetMethod(false) != null
+                                                         && !hiddenTypes.Contains(prop.ViewModelType)
+                                                         && !prop.Member
+                                                                 .GetCustomAttributes(typeof(ObsoleteAttribute), true)
+                                                                 .Any()
+                                          ).OrderBy(prop => prop.ViewModelTypeName)
+                                          .ThenBy(prop => prop.MemberName)
+                                          .ToArray();
             }
+
+            return bindableProperties;
         }
     }
-}
+}

UnityWeld_Editor/OneWayPropertyBindingEditor.cs

@@ -47,10 +47,7 @@ protected override void OnInspector()
             Type viewPropertyType;
             ShowViewPropertyMenu(
                 new GUIContent("View property", "Property on the view to bind to"),
-                PropertyFinder.GetBindableProperties(targetScript.gameObject)
-                    .OrderBy(prop => prop.ViewModelTypeName)
-                    .ThenBy(prop => prop.MemberName)
-                    .ToArray(),
+                PropertyFinder.GetBindableProperties(targetScript.gameObject),
                 updatedValue => targetScript.ViewPropertyName = updatedValue,
                 targetScript.ViewPropertyName,
                 out viewPropertyType

UnityWeld_Editor/TwoWayPropertyBindingEditor.cs

@@ -75,10 +75,7 @@ protected override void OnInspector()
             Type viewPropertyType;
             ShowViewPropertyMenu(
                 new GUIContent("View property", "Property on the view to bind to"),
-                PropertyFinder.GetBindableProperties(targetScript.gameObject)
-                    .OrderBy(prop => prop.ViewModelTypeName)
-                    .ThenBy(prop => prop.MemberName)
-                    .ToArray(),
+                PropertyFinder.GetBindableProperties(targetScript.gameObject),
                 updatedValue => targetScript.ViewPropertyName = updatedValue,
                 targetScript.ViewPropertyName,
                 out viewPropertyType