✨ Implement new AegisAI feedback endpoint #689
Conversation
C-Valen
changed the title
C-Valen
force-pushed
the
task/AEGIS-203-integrate-feedback-endpoint
branch
from
ec81967 to
9fab972
Compare
|
|
||
| await service.sendFeedback({ | ||
| feature: FeatureNameForFeedback[fieldName], | ||
| cveId: cveId || '', |
There was a problem hiding this comment.
I think we would need to use the uuid as a fallback instead of an empty string for a CVE, but Aegis doesn't support that, so perhaps a type assertion or guard here would be best?
There was a problem hiding this comment.
Yes, I set it like this cause currently it is not possible to trigger feedback actions if there is no CVE ID in the flaw. But I can add some guard before that shows a notification and returns if no CVE ID. WDYT?
There was a problem hiding this comment.
I think that makes sense, or just show an error on the form field and use a Zod schema for validation--is that overkill or does that seem sensible?
There was a problem hiding this comment.
Perfect, will go for the notification just cause looks simpler to me
C-Valen
force-pushed
the
task/AEGIS-203-integrate-feedback-endpoint
branch
from
9fab972 to
d6106db
Compare
AEGIS-203 Implement new AegisAI feedback endpoint
Checklist:
Summary:
Required change in OSIM in order to support the new incoming Aegis feedback endpoint mechanism.
Changes:
Considerations:
There is an incoming extension to also provide comments on negative feedback.
This will be handled in a separate ticket and PR cause it is still not supported by the backend.