der: Custom error types in derive macros. #1560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Sequence`, `Enumerated` and `Choice` macros now support `#[asn1(error = Ty)]` attribute that provides a custom error type for `Decode`/`DecodeValue` implementations. This addresses RustCrypto#1559.
baloo
approved these changes
Oct 8, 2024
Member
baloo
left a comment
baloo
left a comment
There was a problem hiding this comment.
That looks good, the only thing that comes to mind would be to use a type to hold the attribute instead.
I've made a PR of what I had in mind in turbocool3r#1.
But it's mostly up to you.
Contributor
Author
|
Thanks, just merged, that's a nice way to reduce that code duplication. One last question is should the attribute be named something like |
Member
|
It's already |
baloo
reviewed
Oct 8, 2024
followup on #1
Member
|
I can merge that later tonight and make an rc.1 release for it. |
der_derive: apply errortype to enumerated
Contributor
Author
|
Merged the second PR, also added docs. I think it's ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for specifying a custom decode error type for
Sequence,EnumeratedandChoicederive macros using the#[asn1(error = Ty)]attribute.This addresses #1559.